Page MenuHomeFreeBSD
Differential D3301

mac address does not update when removing the primary iface from a lagg
ClosedPublic
Actions

Authored by shahark_mellanox.com on Aug 4 2015, 11:18 AM.
Tags
Referenced Files
Unknown Object (File)
Nov 13 2024, 11:35 AM
Unknown Object (File)
Nov 13 2024, 12:53 AM
Unknown Object (File)
Nov 10 2024, 10:22 PM
Unknown Object (File)
Nov 10 2024, 10:28 AM
Unknown Object (File)
Nov 10 2024, 10:18 AM
Unknown Object (File)
Nov 10 2024, 6:22 AM
Unknown Object (File)
Nov 9 2024, 2:53 PM
Unknown Object (File)
Nov 9 2024, 6:32 AM
View All 92 Files
Subscribers
hrs
imp
markb_mellanox.com
sbruno

Details

Reviewers
hiren
hrs
j-nitrology.com
Group Reviewers
network
Commits
rS288980: Fix a bug that caused reinitialization failure of MAC addresses on
Summary

see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201916

Test Plan
  1. ifconfig lagg0 create laggport ifp0 laggport ifp1
  2. ifconfig lagg0 -laggport ifp0

and look at the macs before and after

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

shahark_mellanox.com updated this revision to Diff 7649.Aug 4 2015, 11:18 AM
shahark_mellanox.com retitled this revision from to mac address does not update when removing the primary iface from a lagg .
shahark_mellanox.com updated this object.
shahark_mellanox.com edited the test plan for this revision. (Show Details)
shahark_mellanox.com added a reviewer: hiren.
shahark_mellanox.com set the repository for this revision to rS FreeBSD src repository - subversion.
shahark_mellanox.com added a project: network.
Herald added a subscriber: imp. · View Herald TranscriptAug 4 2015, 11:18 AM
markb_mellanox.com added a subscriber: markb_mellanox.com.Aug 4 2015, 1:00 PM
hiren added a reviewer: j-nitrology.com.Aug 4 2015, 2:15 PM
markb_mellanox.com added a comment.Aug 25 2015, 3:50 AM

Is there any update on this issue?

j-nitrology.com edited edge metadata.Aug 31 2015, 10:16 PM

This tests well and resolves the proposed issue for me on head.

sbruno added a subscriber: sbruno.Oct 4 2015, 10:02 PM

I'm fine with this and can commit it. If there's no further comment I'll commit tonight.

sbruno added a reviewer: network.Oct 4 2015, 10:07 PM
hrs requested changes to this revision.Oct 5 2015, 2:19 AM
hrs added a reviewer: hrs.
hrs added a subscriber: hrs.

I do not think this fix is correct. lagg_port_destroy() should enqueue an lladdr change into sc_lladdr_task when the primary port is removed. Removing the llq_primary == 0 condition causes an unnecessary lladdr update on the primary interface.

Can someone test the following patch?

http://people.allbsd.org/~hrs/FreeBSD/if_lagg.c.20151005-1.diff

This revision now requires changes to proceed.Oct 5 2015, 2:19 AM
shahark_mellanox.com added a comment.Oct 6 2015, 6:52 AM

I've tested the patch and it works

hrs added a comment.Oct 6 2015, 7:03 AM
In D3301#78885, @shahark_mellanox.com wrote:

I've tested the patch and it works

Thank you. I will commit it if nobody objects to it in 24 hours.

Closed by commit rS288980: Fix a bug that caused reinitialization failure of MAC addresses on (authored by hrs). · Explain WhyOct 7 2015, 6:32 AM
This revision was automatically updated to reflect the committed changes.
melifaro mentioned this in D4004: Yet another if_lagg lladdr/eventhandler fix..Oct 26 2015, 10:37 PM

Revision Contents
Changeset List

PathSize
head/
sys/
net/
20 lines

Diff 9207

View Options

head/sys/net/if_lagg.c

Loading...