Retrieve FreeBSD revision number directly from sys/conf/newvers.sh
when building the compiler target triple value, avoiding manual
intervention on every new release.
This patch was split from D19237, so added reviewers/commenters of that change
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| share/mk/src.sys.env.mk | ||
|---|---|---|
| 27 | Never use sed for this. It's always wrong now that we can get the answer directly. It has proven to be historically fragile. sh sys/conf/newvers.sh -V REVISION | cut -d= -f 2 "14.0" | |
Comment Actions
I love this idea, btw. I hope my reaction my reaction to one small detail doesn't obscure this :)
| share/mk/src.sys.env.mk | ||
|---|---|---|
| 27 | OS_REVISION!=eval `sh ${.CURDIR}/git/head/sys/conf/newvers.sh -V REVISION`; echo $$REVISIONworks and eliminates the "" and can cope with all manner of weirdness that some downstreams do to newvers.sh. | |
| share/mk/src.sys.env.mk | ||
|---|---|---|
| 30 | I personally would change this to be " && echo $$REVISION || echo" in the event that $REVISION cannot be properly evaluated. Just my $0.02 USD, though. | |
Comment Actions
Don't worry, luckily wasn't me the one who built that whole sed sentence, I just copied it from other places, otherwise I'd be very sad with how simple solution became now :-D
| share/mk/src.sys.env.mk | ||
|---|---|---|
| 27 | I liked it! Used ${SRCTOP}/sys/conf/newvers.sh instead (I guess */git/head/* is your local path) | |