Details

Reviewers

tuexen
jtl
thj
rrs
glebius

Group Reviewers

transport

Summary

This Diff builds upon D21011. A simplistic reflector for
the received CE, ECT1 and ECT0 marked data bytes in the
AccECN TCP option - which is sent on every ACK, in full.
Only when space is needed for SACK, an abbreviated option
is constructed and sent (if possible).

Potential enhancements: Track which counters changed, and
send only changed counters repeatedly (e.g. 3 times at least)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 56082
Build 52971: arc lint + arc unit

Event Timeline

rscheff created this revision.Aug 23 2022, 9:10 AM

Herald added a reviewer: transport. · View Herald TranscriptAug 23 2022, 9:10 AM

Herald added subscribers: melifaro, imp. · View Herald Transcript

rscheff requested review of this revision.Aug 23 2022, 9:10 AM

Harbormaster completed remote builds in B47066: Diff 109702.Aug 23 2022, 9:10 AM

rebase to main

Harbormaster completed remote builds in B47201: Diff 110016.Aug 31 2022, 1:52 PM

validating this diff against accecn packetdrill scripts from Linux (Ilpo). Once done, will bring this up again.

move ecn sysctls to tcp_ecn.c
go with AccECN options from a compile time option to a global setting
document the new sysctl option
remove outdated comment

Harbormaster completed remote builds in B47660: Diff 111278.Sep 30 2022, 3:44 PM

rebase to main

Harbormaster completed remote builds in B47772: Diff 111633.Oct 11 2022, 8:45 AM

ensure control packets have accecn opt, if enabled

Harbormaster completed remote builds in B47838: Diff 111807.Oct 14 2022, 1:39 PM

gbe added a subscriber: gbe.Oct 26 2022, 8:46 PM

move ecn sysctls to tcp_ecn.c
go with AccECN options from a compile time option to a global setting
document the new sysctl option
remove outdated comment
add logging, and make syncache response honor most recent incoming SYN fields
add logging
more logging
ensure control packets have accecn opt, if enabled
fix packt_this_ack bug
bump man date
received accecn counter into tcpinfo
add more tcpinfo counters
make accecn option counters a struct within tcpcb, which can also be locally allocated (syncache, prior of tcpcb)
initialize to_ae properly
reference properly to counters
bump man page date
remove all logging

Harbormaster completed remote builds in B48203: Diff 112714.Nov 7 2022, 10:18 AM

add ntoh24 and hton24 to improve readability
compact AccECN opt decoding
straighten option output path

Harbormaster completed remote builds in B52102: Diff 123335.Jun 16 2023, 12:34 PM

use temp variable to improve readability

Harbormaster completed remote builds in B52108: Diff 123352.Jun 16 2023, 6:04 PM

rebase to main

Harbormaster completed remote builds in B55461: Diff 132863.Jan 17 2024, 8:09 AM

rebase main

Harbormaster completed remote builds in B56082: Diff 134552.Feb 18 2024, 10:27 AM

Commit	Tree	Parents	Author	Summary	Date
665e932a2693	40c8029b4139	1f85b3bbebf5	Richard Scheffenegger	fix rebase oversight	Feb 18 2024, 10:26 AM
1f85b3bbebf5	b8cfc537d2df	52f72d8758c7	Richard Scheffenegger	no logging	Jan 17 2024, 12:05 AM
52f72d8758c7	368dde9036d3	d4cc374b2ca0	Richard Scheffenegger	add logging	Jun 26 2023, 10:55 AM
d4cc374b2ca0	ad87aaa91056	74780146f91e	Richard Scheffenegger	fix RTO fallback	Jun 20 2023, 9:00 PM
74780146f91e	b8cfc537d2df	a7119bda76fb	Richard Scheffenegger	set TOF_ flags on input processing of AccECN option	Jun 20 2023, 8:32 PM
a7119bda76fb	b5da026bdc2b	a3db6bad08f7	Richard Scheffenegger	move all accecn counters into struct and add primitive overflow protection for… (Show More…)	Jun 20 2023, 5:46 PM
a3db6bad08f7	a6cdf79dc0f2	f5ba465e9262	Richard Scheffenegger	move disabling AccECN option from fastpath to RTO path	Jun 20 2023, 4:32 PM
f5ba465e9262	2cca5ed05af4	d3f9c46b44d6	Richard Scheffenegger	disable AccECN option after multiple RTOs.	Jun 20 2023, 4:28 PM
d3f9c46b44d6	ccc78673c845	0b4571743d36	Richard Scheffenegger	keep AccECN option in tp->t_flags (fastpath; disable for traversal issues)	Jun 20 2023, 4:09 PM
0b4571743d36	b6c8a241ca4b	0e0bb3ba416e	Richard Scheffenegger	add AccECN option to ACE flows after global option was disabled	Jun 20 2023, 11:18 AM
0e0bb3ba416e	e69c7870771c	bb8fd093e7a7	Richard Scheffenegger	use temp variable to improve readability	Jun 16 2023, 6:03 PM
bb8fd093e7a7	81585abdf9fe	1ef598c9e2d3	Richard Scheffenegger	fix whitespace	Jun 16 2023, 12:33 PM
1ef598c9e2d3	3f756745020c	677968b7868d	Richard Scheffenegger	straighten option output path	Jun 16 2023, 12:30 PM
677968b7868d	eebdf48a986b	f701d162c541	Richard Scheffenegger	compact AccECN opt decoding	Jun 16 2023, 12:00 PM
f701d162c541	59fb7f07156a	6d8636c2f444	Richard Scheffenegger	add ntoh24 and hton24 to improve readability	Jun 16 2023, 11:17 AM
6d8636c2f444	eae6c8791498	a45eec5eb6d5	Richard Scheffenegger	clean up manual rebase	Jun 14 2023, 1:20 AM
a45eec5eb6d5	615d8e661fa4	502dec488d3b	Richard Scheffenegger	remove all logging	Nov 7 2022, 10:17 AM
502dec488d3b	c8ca77ab8c0a	20db4ab4e437	Richard Scheffenegger	reference properly to counters	Nov 7 2022, 9:35 AM
20db4ab4e437	150b6599c77c	5102368eb298	Richard Scheffenegger	initialize to_ae properly	Nov 6 2022, 4:51 PM
5102368eb298	9b645282ac96	f669d88d8964	Richard Scheffenegger	make accecn option counters a struct within tcpcb, which can also be locally… (Show More…)	Nov 6 2022, 3:51 PM
f669d88d8964	894fc7b9a403	f6f130230f48	Richard Scheffenegger	add more tcpinfo counters	Nov 6 2022, 2:20 PM
f6f130230f48	142fad3f6454	acaa5df84684	Richard Scheffenegger	received accecn counter into tcpinfo	Nov 6 2022, 11:53 AM
acaa5df84684	151af306f02c	179a7b327159	Richard Scheffenegger	fix packt_this_ack bug	Nov 5 2022, 4:25 PM
179a7b327159	8ff94572678f	08d9efd635a0	Richard Scheffenegger	ensure control packets have accecn opt, if enabled	Oct 14 2022, 1:38 PM
08d9efd635a0	b5af46d05a63	b2a7d7b6f60b	Richard Scheffenegger	more logging	Oct 12 2022, 5:32 PM
b2a7d7b6f60b	d9aa6945e838	acb32b3d0b7c	Richard Scheffenegger	add logging	Oct 12 2022, 4:08 PM
acb32b3d0b7c	d8c9fce7a988	45f1fa8a7c70	Richard Scheffenegger	add logging, and make syncache response honor most recent incoming SYN fields	Oct 4 2022, 2:18 PM
45f1fa8a7c70	d154d75c90e4	73069b560c76	Richard Scheffenegger	remove outdated comment	Sep 30 2022, 3:43 PM
73069b560c76	6a572208b108	8fba03e02b65	Richard Scheffenegger	document the new sysctl option	Sep 30 2022, 3:41 PM
8fba03e02b65	aa5b16b547c2	3bf7eee7c744	Richard Scheffenegger	go with AccECN options from a compile time option to a global setting	Sep 30 2022, 3:36 PM
3bf7eee7c744	c1b48c812854	26c6bc00b4ed	Richard Scheffenegger	move ecn sysctls to tcp_ecn.c	Sep 30 2022, 12:42 PM
26c6bc00b4ed	c7960072744f	e6f8eb02b09a	Richard Scheffenegger	Implement AccECN option (w/ early assigned option number) (Show More…)	Aug 23 2022, 8:58 AM
e6f8eb02b09a	166d8ca491a5	a6282a7ee5d6	Richard Scheffenegger	add accecn-opt to syncache, and initialize values; NOTE: fixup for DATA in SYN.. (Show More…)	Aug 22 2022, 1:21 PM
a6282a7ee5d6	daffd042e550	441a0a9dc328	Richard Scheffenegger	use early assigned TCP options codepoints	Aug 7 2022, 6:41 AM
441a0a9dc328	6eecdebf002b	db63539c1924	Richard Scheffenegger	make experimental AccECN option align with Linux	Jul 25 2022, 12:52 AM
db63539c1924	5a609c137032	9541ee043211	Richard Scheffenegger	use 0xac and 0xae for AccECN option	Jul 24 2022, 3:29 PM
9541ee043211	f375ad31aab5	2fefdf620433	Richard Scheffenegger	initialize local accecn byte counters	Feb 12 2022, 11:17 PM
2fefdf620433	14ecc4d779de	bbae4bf006ec	Richard Scheffenegger	fix TCP_ACCECNOPT compile option fix experimental tcpopt	Feb 11 2022, 3:52 PM
bbae4bf006ec	1ae875eb9c48	faf49c51fdf5	Richard Scheffenegger	make AccECN TCP options a compile time option	Feb 11 2022, 12:37 PM
faf49c51fdf5	5a768c53e8b1	dd85412819e3	Richard Scheffenegger	bracket AccECN option with compile #ifdef TCP_ACCECNOPT	Feb 11 2022, 12:11 PM
dd85412819e3	77b0b5068dfc	c06e2409494b	Richard Scheffenegger	first attempt at providing AccECN option	Feb 7 2022, 2:32 AM
c06e2409494b	60dff5ee21d3	407025a18a45	Richard Scheffenegger	manual rebase to main	Jan 31 2022, 12:22 PM
407025a18a45	5f0c53ba24e7	92b832a76502	Richard Scheffenegger	remove logging again	Feb 6 2022, 2:14 PM
92b832a76502	136d24b7320b	e57a94d36843	Richard Scheffenegger	add logging to troubleshoot iptos oddity	Feb 2 2022, 10:07 PM
e57a94d36843	60dff5ee21d3	20c14642b3e1	Richard Scheffenegger	manual rebase to main	Jan 31 2022, 12:22 PM
20c14642b3e1	c71e1cbf6abb	a8863078f7c8	Richard Scheffenegger	removing logging	Jul 24 2022, 2:40 AM
a8863078f7c8	7c42b4899f01	301dd1e66d36	Richard Scheffenegger	fixed 2 oversights, added logging	Jul 24 2022, 2:37 AM
301dd1e66d36	c71e1cbf6abb	89dca5c43df2	Richard Scheffenegger	thflags is fully propulated for KASSERT fix syn-sent ecn negotiation	Feb 10 2022, 3:15 AM
89dca5c43df2	b3dcec0664f3	cdbf8705897d	Richard Scheffenegger	cleaning up a set of KMOD_ macros, and nicifying source code	Feb 6 2022, 9:20 PM
cdbf8705897d	5f0c53ba24e7	7713ef94069c	Richard Scheffenegger	remove logging again	Feb 6 2022, 2:14 PM
7713ef94069c	89a1b89295c0	7fc83cde70dd	Richard Scheffenegger	add logging to troubleshoot iptos oddity	Feb 2 2022, 10:07 PM
7fc83cde70dd	5f6ee39d08fa	8f487a4cfb86	Richard Scheffenegger	use uint16_t consistently for thflags, rather than passing pointers	Feb 2 2022, 9:13 PM
8f487a4cfb86	9349bd604427	4d7ae08b8c02	Richard Scheffenegger	troubleshoot rack (ect0 on control packet)	Feb 2 2022, 6:48 PM
4d7ae08b8c02	6bdcc472b8f5	0835ebc477be	Richard Scheffenegger	fix up rack fast_output	Feb 2 2022, 4:30 PM
0835ebc477be	5f1020766b00	8b830cb758da	Richard Scheffenegger	fixing cwr to go only with new data, update rack	Feb 2 2022, 4:13 PM
8b830cb758da	cdb5e244f9d6	acf063bb5c65	Richard Scheffenegger	do proper output handling also for parallel SYN	Feb 2 2022, 2:14 PM
acf063bb5c65	bd42f441fd2c	bee3f6eb9c0e	Richard Scheffenegger	proper logging when handling ecn	Feb 2 2022, 12:03 PM
bee3f6eb9c0e	6ca3fd2bc33c	c35c61a7c414	Richard Scheffenegger	adding logging output, handle parallel SYN for ECN	Feb 2 2022, 10:05 AM
c35c61a7c414	8b60ce959faa	dff58f823a59	Richard Scheffenegger	prepare rack to handle AccECN	Feb 1 2022, 1:40 PM
dff58f823a59	5da5f7b9d09e	a3ac7dec0656	Richard Scheffenegger	manual rebase to main	Jan 31 2022, 12:22 PM
a3ac7dec0656	83bce9dd45c3	b6552c8805bd	Richard Scheffenegger	- rebase to main - move tcp_set_flag() past ECN in rack_fast_output()	Feb 5 2022, 8:19 PM
b6552c8805bd	c76f8fcd1e5b	4c12a956bebb	Richard Scheffenegger	rebase to main, set flags in rsm_fast_output after ecn changes	Feb 4 2022, 11:16 PM
4c12a956bebb	129453227b2b	f2ff4e030dd0	Richard Scheffenegger	Add/update AccECN related statistics and numbers (Show More…)	Feb 3 2022, 8:51 PM
f2ff4e030dd0	2d361c647f17	465af381d03f	Richard Scheffenegger	reconsile recent commits with local changes	Feb 3 2022, 8:34 PM
465af381d03f	f4b63000c1dc	38f4eb8f5885	Richard Scheffenegger	add logging to troubleshoot iptos oddity	Feb 2 2022, 10:07 PM
38f4eb8f5885	a20ed001160a	e1241058b975	Richard Scheffenegger	use uint16_t consistently for thflags, rather than passing pointers	Feb 2 2022, 9:13 PM
e1241058b975	4043370dc162	5485cca9910c	Richard Scheffenegger	troubleshoot rack (ect0 on control packet)	Feb 2 2022, 6:48 PM
5485cca9910c	1e38c427dc45	2f7608a3c744	Richard Scheffenegger	fixing cwr to go only with new data, update rack	Feb 2 2022, 4:13 PM
2f7608a3c744	8105b45ebc6b	685942bcc6a7	Richard Scheffenegger	do proper output handling also for parallel SYN	Feb 2 2022, 2:14 PM
685942bcc6a7	ebd58ebc13d9	ae904a2ca02b	Richard Scheffenegger	proper logging when handling ecn	Feb 2 2022, 12:03 PM
ae904a2ca02b	58595ab4b95c	15c51beb3884	Richard Scheffenegger	adding logging output, handle parallel SYN for ECN	Feb 2 2022, 10:05 AM
15c51beb3884	7b6dc556317d	7555afcc8e8b	Richard Scheffenegger	put more common ecn code to tcp_ecn.c	Feb 1 2022, 9:00 PM
7555afcc8e8b	0f3b3162392a	7d8ef9d5c80c	Richard Scheffenegger	prepare rack to handle AccECN	Feb 1 2022, 1:40 PM
7d8ef9d5c80c	0f8211284fa5	4beb79947892	Richard Scheffenegger	manual rebase to main	Jan 31 2022, 12:22 PM
4beb79947892	26aae90e8742	1b86538cccc5	Richard Scheffenegger	replace all macro references	Feb 2 2022, 7:33 PM
1b86538cccc5	bb4ebff18680	a1bdcd331549	Richard Scheffenegger	use static inline function instead of macro	Feb 2 2022, 7:10 PM
a1bdcd331549	2b6e6f74fad3	44702eb11358	Richard Scheffenegger	fix typo	Feb 1 2022, 4:21 PM
44702eb11358	4befaa49784d	5ecaea4446a7	Richard Scheffenegger	Access TCP Header Flags via accessor MACRO (Show More…)	Feb 1 2022, 4:06 PM
5ecaea4446a7	26aae90e8742	cd6f01c4d62d	Richard Scheffenegger	only access exsting tp	Oct 13 2022, 5:50 AM
cd6f01c4d62d	a3aa2633401e	2389fd7eac3b	Richard Scheffenegger	don't assume tp, thflag exist	Oct 13 2022, 5:45 AM
2389fd7eac3b	102cd24d5b14	078a31136c8c	Richard Scheffenegger	tcp_respond should react as expected for ECN in preparation for ECN++, AccECN	Oct 12 2022, 6:15 PM

Implement AccECN option (w/ early assigned option number)
Needs ReviewPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 134552

share/man/man4/tcp.4

sys/netinet/tcp.h

sys/netinet/tcp_ecn.h

sys/netinet/tcp_ecn.c

sys/netinet/tcp_input.c

sys/netinet/tcp_output.c

sys/netinet/tcp_subr.c

sys/netinet/tcp_syncache.c

sys/netinet/tcp_timer.c

sys/netinet/tcp_usrreq.c

sys/netinet/tcp_var.h

Implement AccECN option (w/ early assigned option number)Needs ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 134552

share/man/man4/tcp.4

sys/netinet/tcp.h

sys/netinet/tcp_ecn.h

sys/netinet/tcp_ecn.c

sys/netinet/tcp_input.c

sys/netinet/tcp_output.c

sys/netinet/tcp_subr.c

sys/netinet/tcp_syncache.c

sys/netinet/tcp_timer.c

sys/netinet/tcp_usrreq.c

sys/netinet/tcp_var.h

Implement AccECN option (w/ early assigned option number)
Needs ReviewPublic
Actions

Revision Contents
Changeset List