Details

Reviewers

tuexen
jtl
thj
rrs
glebius

Group Reviewers

transport

Summary

This Diff builds upon D21011. A simplistic reflector for
the received CE, ECT1 and ECT0 marked data bytes in the
AccECN TCP option - which is sent on every ACK, in full.
Only when space is needed for SACK, an abbreviated option
is constructed and sent (if possible).

Potential enhancements: Track which counters changed, and
send only changed counters repeatedly (e.g. 3 times at least)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 47838
Build 44725: arc lint + arc unit

Event Timeline

rscheff created this revision.Aug 23 2022, 9:10 AM

Herald added a reviewer: transport. · View Herald TranscriptAug 23 2022, 9:10 AM

Herald added subscribers: melifaro, imp. · View Herald Transcript

rscheff requested review of this revision.Aug 23 2022, 9:10 AM

Harbormaster completed remote builds in B47066: Diff 109702.Aug 23 2022, 9:10 AM

rebase to main

Harbormaster completed remote builds in B47201: Diff 110016.Aug 31 2022, 1:52 PM

validating this diff against accecn packetdrill scripts from Linux (Ilpo). Once done, will bring this up again.

move ecn sysctls to tcp_ecn.c
go with AccECN options from a compile time option to a global setting
document the new sysctl option
remove outdated comment

Harbormaster completed remote builds in B47660: Diff 111278.Sep 30 2022, 3:44 PM

rebase to main

Harbormaster completed remote builds in B47772: Diff 111633.Oct 11 2022, 8:45 AM

ensure control packets have accecn opt, if enabled

Harbormaster completed remote builds in B47838: Diff 111807.Oct 14 2022, 1:39 PM

gbe added a subscriber: gbe.Oct 26 2022, 8:46 PM

move ecn sysctls to tcp_ecn.c
go with AccECN options from a compile time option to a global setting
document the new sysctl option
remove outdated comment
add logging, and make syncache response honor most recent incoming SYN fields
add logging
more logging
ensure control packets have accecn opt, if enabled
fix packt_this_ack bug
bump man date
received accecn counter into tcpinfo
add more tcpinfo counters
make accecn option counters a struct within tcpcb, which can also be locally allocated (syncache, prior of tcpcb)
initialize to_ae properly
reference properly to counters
bump man page date
remove all logging

Harbormaster completed remote builds in B48203: Diff 112714.Nov 7 2022, 10:18 AM

add ntoh24 and hton24 to improve readability
compact AccECN opt decoding
straighten option output path

Harbormaster completed remote builds in B52102: Diff 123335.Jun 16 2023, 12:34 PM

use temp variable to improve readability

Harbormaster completed remote builds in B52108: Diff 123352.Jun 16 2023, 6:04 PM

rebase to main

Harbormaster completed remote builds in B55461: Diff 132863.Jan 17 2024, 8:09 AM

rebase main

Harbormaster completed remote builds in B56082: Diff 134552.Feb 18 2024, 10:27 AM

Implement AccECN option (w/ early assigned option number)
Needs ReviewPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 111807

share/man/man4/tcp.4

sys/netinet/tcp.h

sys/netinet/tcp_ecn.h

sys/netinet/tcp_ecn.c

sys/netinet/tcp_input.c

sys/netinet/tcp_output.c

sys/netinet/tcp_stacks/rack.c

sys/netinet/tcp_subr.c

sys/netinet/tcp_syncache.c

sys/netinet/tcp_timer.c

sys/netinet/tcp_var.h

Implement AccECN option (w/ early assigned option number)Needs ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 111807

share/man/man4/tcp.4

sys/netinet/tcp.h

sys/netinet/tcp_ecn.h

sys/netinet/tcp_ecn.c

sys/netinet/tcp_input.c

sys/netinet/tcp_output.c

sys/netinet/tcp_stacks/rack.c

sys/netinet/tcp_subr.c

sys/netinet/tcp_syncache.c

sys/netinet/tcp_timer.c

sys/netinet/tcp_var.h

Implement AccECN option (w/ early assigned option number)
Needs ReviewPublic
Actions

Revision Contents
Changeset List