Page MenuHomeFreeBSD

lang/gcc11: Fix conflict on libgccjit.h and libgccjig++.h
ClosedPublic

Authored by salvadore on Nov 2 2022, 10:41 PM.
Tags
None
Referenced Files
F81969756: D37242.diff
Sat, Dec 14, 10:36 AM
Unknown Object (File)
Apr 7 2024, 10:59 PM
Unknown Object (File)
Mar 31 2024, 10:53 AM
Unknown Object (File)
Mar 28 2024, 6:05 PM
Unknown Object (File)
Mar 13 2024, 3:01 AM
Unknown Object (File)
Feb 28 2024, 7:09 PM
Unknown Object (File)
Feb 15 2024, 9:40 PM
Unknown Object (File)
Jan 30 2024, 7:28 PM
Subscribers

Details

Summary

GCC 11, GCC 12 and GCC 13 install libgccjit.h and libgccjit++.h in the
same directory.

Fix conflict for GCC 11, which is GCC_DEFAULT, by installing those files
in a directory specific to GCC 11.

PR: 257060
Reported by: Ting-Wei Lan <lantw44@gmail.com>
See also: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101491

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 48124
Build 45011: arc lint + arc unit

Event Timeline

Like it! Maybe share this with gcc-patches@gcc.gnu.org before adding it here to see what feedback the GCC folks may have (but that's just a suggestion, not required).

This revision is now accepted and ready to land.Nov 3 2022, 7:25 AM

Like it! Maybe share this with gcc-patches@gcc.gnu.org before adding it here to see what feedback the GCC folks may have (but that's just a suggestion, not required).

I think it is better to get the patch in the ports tree before, so the GCC developers see that it works. As you know, the issue was already being discussed in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101491 but the discussion has not go forward since 2022-01-20, so I think showing something that actually works will be more effective.

So I still can't install the other gcc ports simultaneously? In any case I've got local patches that just disable the libgccjit headers from being packaged at all, since I do not care about them. But this should really be solved upstream.

In D37242#845907, @dim wrote:

So I still can't install the other gcc ports simultaneously?

After this patch it will be possible to install lang/gcc11 and lang/gcc12{-devel} simultaneously or lang/gcc11 and lang/gcc13-devel simultaneously. I plan to spread the patch on all the gcc ports so that GCC 11, 12 and 13 can be all installed simultaneously. This patch is only the first step, the most urgent since it is the one that users can run into more easily as at the moment GCC_DEFAULT=11.

Hopefully, the patch or a better version of it will also be merged upstream so that I will not need to forward it manually to all gcc ports. But before sending it to upstream, I think it is better to show the GCC developers that it actually works by committing it at least to lang/gcc11.

Thanks! I guess I'm maybe a bit unusual, because I typically install almost all gcc ports (well, of the -devel ones only 13-devel). But indeed most users will get the default gcc port due to some random dependency, and then it's nice if they can at least install gcc11 too.