WIP: if_gif: Demonstrate usage of route caching framework
Needs ReviewPublic
Actions

Authored by zlei on Dec 20 2022, 12:48 PM.

Details

Reviewers

melifaro
kp
ae

Group Reviewers

network

Summary

First consumer of D37757.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

zlei created this revision.Dec 20 2022, 12:48 PM

Herald added subscribers: glebius, donner, imp. · View Herald TranscriptDec 20 2022, 12:48 PM

zlei requested review of this revision.Dec 20 2022, 12:48 PM

zlei mentioned this in D37757: WIP: Add scalable route caching framework.Dec 20 2022, 12:54 PM

ae added inline comments.Dec 20 2022, 1:02 PM

sys/net/if_gif.c
162	entire softc is allocated with M_ZERO, so there is no need in bzero().

zlei added a parent revision: D37757: WIP: Add scalable route caching framework.Dec 20 2022, 1:20 PM

zlei added inline comments.Dec 20 2022, 1:26 PM

sys/net/if_gif.c
162	Good catch!

Address @ae 's comment.

zlei marked an inline comment as done.Dec 20 2022, 1:33 PM

zlei mentioned this in D36501: lio: Remove unneeded include..Jan 11 2023, 8:49 AM

Revision Contents
Changeset List

Path

Size

sys/

net/

if_gif.h

2 line(s)

if_gif.c

18 line(s)

netgraph/

ng_gif.c

5 line(s)

netinet/

in_gif.c

13 line(s)

netinet6/

in6_gif.c

14 line(s)

Diff 114318

View Options

sys/net/if_gif.h

View Options

sys/net/if_gif.c

View Options

sys/netgraph/ng_gif.c

View Options

sys/netinet/in_gif.c

View Options

WIP: if_gif: Demonstrate usage of route caching frameworkNeeds ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 114318

sys/net/if_gif.h

sys/net/if_gif.c

sys/netgraph/ng_gif.c

sys/netinet/in_gif.c

sys/netinet6/in6_gif.c

WIP: if_gif: Demonstrate usage of route caching framework
Needs ReviewPublic
Actions

Revision Contents
Changeset List