Skip tarfs regression test if module doesn't exist
ClosedPublic
Actions

Authored by olivier on Feb 28 2023, 8:02 PM.

Details

Reviewers

des
asomers

Group Reviewers

tests

Commits

rGe78dc78e517a: testing: skip tarfs tests if module is not loadable.

Summary

When building customized FreeBSD without tarfs module, this regression test fail because
it can't load the module.

Test Plan

 mv /boot/kernel/tarfs.ko /boot/kernel/tarfs.ko.bak
# kyua test sys/fs/tarfs/
sys/fs/tarfs/tarfs_test:tarfs_basic  ->  skipped: This test requires tarfs and could not load it  [0.020s]
sys/fs/tarfs/tarfs_test:tarfs_notdir_device  ->  skipped: This test requires tarfs and could not load it  [0.020s]
sys/fs/tarfs/tarfs_test:tarfs_notdir_dot  ->  skipped: This test requires tarfs and could not load it  [0.019s]
sys/fs/tarfs/tarfs_test:tarfs_notdir_dotdot  ->  skipped: This test requires tarfs and could not load it  [0.019s]
sys/fs/tarfs/tarfs_test:tarfs_notdir_file  ->  skipped: This test requires tarfs and could not load it  [0.019s]

Results file id is usr_tests.20230228-200204-811621
Results saved to /root/.kyua/store/results.usr_tests.20230228-200204-811621.db

5/5 passed (0 failed)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

olivier requested review of this revision.Feb 28 2023, 8:02 PM

olivier created this revision.

asomers accepted this revision.Feb 28 2023, 8:10 PM

This revision is now accepted and ready to land.Feb 28 2023, 8:10 PM

The kldload check function seems like it should be in a common function. Also: I might reword the message to state: “This test requires the tarfs kernel module (not available).”

tests/sys/fs/tarfs/tarfs_test.sh
51	Should this use umount -f ?

ngie added inline comments.Mar 1 2023, 1:38 PM

tests/sys/fs/tarfs/tarfs_test.sh
51	Or maybe a different sanity check to run beforehand, like ‘test -d “${mnt}”’?

In D38828#884135, @ngie wrote:

The kldload check function seems like it should be in a common function. Also: I might reword the message to state: “This test requires the tarfs kernel module (not available).”

About the "not available", I didn't add this precision because in some case it could be a loading failure too (like a child module not available).

Closed by commit rGe78dc78e517a: testing: skip tarfs tests if module is not loadable. (authored by olivier). · Explain WhyMar 1 2023, 9:24 PM

This revision was automatically updated to reflect the committed changes.

olivier added a commit: rGe78dc78e517a: testing: skip tarfs tests if module is not loadable..

Herald added a subscriber: imp. · View Herald TranscriptMar 1 2023, 9:24 PM