ifnet: add if_foreach_sleep() to allow ifnet iterations with sleep.
ClosedPublic
Actions

Authored by melifaro on Mar 4 2023, 10:10 AM.

Details

Reviewers

glebius
emaste
jhibbits
dchagin

Group Reviewers

network

Commits

rGdf2b419a4105: ifnet: add if_foreach_sleep() to allow ifnet iterations with sleep.

Summary

Some kernel customers exporting network interfaces may require sleep during the iteration. Netlink and linsysfs can be the examples.

This change adds the generic iteration interface, similar to if_foreach(), but allowing the callback to sleep.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

melifaro created this revision.Mar 4 2023, 10:10 AM

Herald added subscribers: glebius, ae, imp. · View Herald TranscriptMar 4 2023, 10:10 AM

melifaro requested review of this revision.Mar 4 2023, 10:10 AM

Harbormaster completed remote builds in B50140: Diff 118317.Mar 4 2023, 10:10 AM

melifaro edited the summary of this revision. (Show Details)Mar 4 2023, 10:12 AM

melifaro added reviewers: network, glebius, emaste, jhibbits, dchagin.

Update match function signature.

Harbormaster completed remote builds in B50141: Diff 118318.Mar 4 2023, 10:29 AM

dchagin added inline comments.Mar 4 2023, 10:30 AM

sys/net/if.c
4591	seems should be error = cb();

Fix error handling.

Harbormaster completed remote builds in B50142: Diff 118319.Mar 4 2023, 10:46 AM

https://reviews.freebsd.org/D38901
Excelent to me

melifaro added a child revision: D38907: netlink: use newly-added if_foreach_sleep() to iterate over the interface list..Mar 4 2023, 3:17 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 6 2023, 3:09 PM

Closed by commit rGdf2b419a4105: ifnet: add if_foreach_sleep() to allow ifnet iterations with sleep.. · Explain Why

This revision was automatically updated to reflect the committed changes.

melifaro added a commit: rGdf2b419a4105: ifnet: add if_foreach_sleep() to allow ifnet iterations with sleep..

As discussed in email, if_foreach_sleep() sounds like the loop itself inserts a delay. I suggest changing it to if_foreach_sleepable(), which more accurately conveys that it can sleep (or use callbacks that can sleep), not that that it does sleep.