Differential D40421

ipmi: add Block Transfer interface support.
ClosedPublic
Actions

Authored by ae on Jun 5 2023, 6:37 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 17, 3:59 AM

	Unknown Object (File)
	Thu, Nov 14, 1:50 AM

	Unknown Object (File)
	Tue, Nov 12, 1:56 PM

	Unknown Object (File)
	Tue, Nov 12, 10:28 AM

	Unknown Object (File)
	Mon, Nov 11, 8:49 AM

	Unknown Object (File)
	Mon, Nov 11, 7:40 AM

	Unknown Object (File)
	Sat, Nov 9, 6:14 PM

	Unknown Object (File)
	Sat, Nov 9, 1:00 PM

View All 36 Files

Subscribers

Details

Reviewers

ambrisko
andrew

Commits

rG53380074a162: ipmi: add Block Transfer interface support
rG1f166509895d: ipmi: add Block Transfer interface support

Summary

Patched module is now able to detect and attach to BMC:

ipmi0: <IPMI System Interface> on isa0
ipmi0: BT mode found at io 0xe4 alignment 0x1 on isa
ipmi0: IPMI device rev. 1, firmware rev. 6.48, version 2.0, device support mask 0xaf
ipmi0: Number of channels 0
ipmi0: Attached watchdog
ipmi0: Establishing power cycle handler

ipmitools also works:

# ipmitool channel info
Channel 0xf info:
  Channel Medium Type   : System Interface
  Channel Protocol Type : BT-15
  Session Support       : session-less
  Active Session Count  : 0
  Protocol Vendor ID    : 7154

dmidecode:

Handle 0x0037, DMI type 38, 18 bytes
IPMI Device Information
        Interface Type: BT (Block Transfer)
        Specification Version: 2.0
        I2C Slave Address: 0x10
        NV Storage Device: Not Present
        Base Address: 0x00000000000000E4 (I/O)
        Register Spacing: Successive Byte Boundaries

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ae created this revision.Jun 5 2023, 6:37 AM

ae held this revision as a draft.

Herald added subscribers: emaste, andrew, imp. · View Herald TranscriptJun 5 2023, 6:37 AM

Harbormaster completed remote builds in B51902: Diff 122840.Jun 5 2023, 6:37 AM

ae published this revision for review.Jun 5 2023, 6:40 AM

ae edited the summary of this revision. (Show Details)Jun 5 2023, 6:46 AM

ae added a reviewer: ambrisko.Jun 5 2023, 7:15 AM

This looks generally good.
I think I have an arm server with bt mode. Any chance it will work?

Thanks for adding BT.

This revision is now accepted and ready to land.Jun 5 2023, 3:02 PM

In D40421#920356, @imp wrote:

This looks generally good.
I think I have an arm server with bt mode. Any chance it will work?

I hope this should work. It would be nice if you try test it.

Closed by commit rG1f166509895d: ipmi: add Block Transfer interface support (authored by ae). · Explain WhyJun 7 2023, 9:33 AM

This revision was automatically updated to reflect the committed changes.

ae added a commit: rG1f166509895d: ipmi: add Block Transfer interface support.

ae added a commit: rG53380074a162: ipmi: add Block Transfer interface support.Jun 25 2023, 6:41 PM

Herald added a reviewer: andrew. · View Herald TranscriptJun 25 2023, 6:41 PM

Herald added a reviewer: andrew. · View Herald Transcript

Revision Contents
Changeset List

Path

Size

sys/

conf/

1 line

1 line

dev/

ipmi/

19 lines

296 lines

19 lines

28 lines

1 line

19 lines

modules/

ipmi/

2 lines

Diff 122914

sys/conf/files.arm64

Loading...

sys/conf/files.x86

Loading...

sys/dev/ipmi/ipmi_acpi.c

Loading...

sys/dev/ipmi/ipmi_bt.c

Loading...

sys/dev/ipmi/ipmi_isa.c

Loading...

sys/dev/ipmi/ipmi_pci.c

Loading...

sys/dev/ipmi/ipmi_smbios.c

Loading...

sys/dev/ipmi/ipmivars.h

Loading...

sys/modules/ipmi/Makefile

Loading...