This patch fixes:
- IPv6 TSO on em(4)
- Limits TSO to IPv4 on lem(4) based on NetBSD and Linux
Details
Details
- Reviewers
markj marius shurd - Group Reviewers
Intel Networking Restricted Owners Package (Owns No Changed Paths) - Commits
- rGb8e5efdd24b0: e1000: Some fixes for hardware capabilities
rGc68db90db192: e1000: Automask TSO on lem(4)/em(4) 10/100 Ethernet
rGe9cd4a8fee58: e1000: Fix lem(4)/em(4) TSO6
rGf1b5488f7bba: e1000: Enable TSO for lem(4) and em(4)
rG2ddf24f8f525: e1000: Automask TSO on lem(4)/em(4) 10/100 Ethernet
rGe1353dcb63bb: e1000: Fix lem(4)/em(4) TSO6
Tested on I219, 82541GI, 82546EB, VirtualBox lem(4), qemu lem(4), VMWare lem(4), VMware 82574L
TSO is not enabled on lem(4) or em(4) by default
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| sys/dev/e1000/em_txrx.c | ||
|---|---|---|
| 163 | I moved this here to avoid duplicating conditionals for IPv4 vs IPv6 but am open to style suggestion. | |
| sys/dev/e1000/if_em.c | ||
| 784 | According to Linux lem(4) doesn't support IPv6 TSO, but they do enable TSO for IPv4 by default for (>82544, !82547). I can't see any particular reason while TSOv6 doesn't work here but intel has never been clear on all the bugs on the entire family of chips. | |
| sys/dev/e1000/em_txrx.c | ||
|---|---|---|
| 198 | I added this previously based on reading the SDM noting a slightly different behavior.. but I can't think of why it would matter in reality, because you wouldn't be doing a lower (IP) checksum on IPv6 anyway. | |
| sys/dev/e1000/if_em.c | ||
|---|---|---|
| 1409 | Looks like SPEED_1000 (which == 1000 of course). Also, do any types < igb_mac_min support 2500? | |
| sys/dev/e1000/if_em.c | ||
|---|---|---|
| 1409 | I think the only device covered by this driver that could possibly support 2500 link speed would be i354, which would be above igb_mac_min. | |
Comment Actions
@shurd I added some smarts to the TSO automask. Also added a sysctl for people that want to opt out of.