netlink: fix adding an interface route
ClosedPublic
Actions

Authored by takahiro.kurosawa_gmail.com on Aug 5 2023, 5:23 AM.

Details

Reviewers

melifaro
rcm

Group Reviewers

network

Commits

rG7a4a122f9731: netlink: fix adding an interface route
rGf818559774cb: netlink: fix adding an interface route

Summary

"route add <host> -iface <netif>" for a netif without an IPv4/IPv6 address
fails with EINVAL. Need to use a link-level ifaddr for gw if an ifaddr
for dst is not found as the rtsock-based implementation does.

Test Plan

ifconfig tun0 create
ifconfig tun0 up
route add 192.0.2.1 -iface tun0

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

takahiro.kurosawa_gmail.com created this revision.Aug 5 2023, 5:23 AM

Herald added subscribers: glebius, imp. · View Herald TranscriptAug 5 2023, 5:23 AM

takahiro.kurosawa_gmail.com requested review of this revision.Aug 5 2023, 5:23 AM

jlduran_gmail.com mentioned this in D41436: netlink: Add tests when adding an interface route.Aug 12 2023, 4:31 PM

jlduran_gmail.com added a child revision: D41436: netlink: Add tests when adding an interface route.

zlei added a subscriber: zlei.Aug 15 2023, 4:01 AM

@melifaro does this change seem correct to you?

emaste added a subscriber: emaste.Sep 6 2023, 7:03 PM

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275341
Fixes:

# ifconfig wg1 create
# ifconfig wg1 up
# route -n add 10.2.0.0/24 -interface wg1

rcm added a reviewer: rcm.Nov 28 2023, 2:39 PM

This looks good to me.

I have a separate patch that introduces v4 and v6 atf-sh test cases for sbin/route that I will land along with D41436 when it gets a v6 test case soon.

This revision is now accepted and ready to land.Nov 28 2023, 6:00 PM

Closed by commit rGf818559774cb: netlink: fix adding an interface route (authored by takahiro.kurosawa_gmail.com, committed by rcm). · Explain WhyNov 28 2023, 9:13 PM

This revision was automatically updated to reflect the committed changes.

rcm added a commit: rGf818559774cb: netlink: fix adding an interface route.

rcm mentioned this in rGca7edd0d2c33: route: introduce add interface route test cases.Nov 28 2023, 9:16 PM

zlei added a commit: rG7a4a122f9731: netlink: fix adding an interface route.Mar 14 2024, 8:30 AM

zlei mentioned this in rG9a2b4665958e: route: introduce add interface route test cases.Mar 14 2024, 9:55 AM