Differential D41729
GPU firmware: Load i915 and amdgpu firmware failed. Authored by vico.chern_qq.com on Sep 5 2023, 10:58 AM. Tags None Referenced Files
Details
Description: While load i915 driver (drm 5.15 from github), the GPU firmwares can NOT be loaded due to looking up FW failed. For example, i915 FW name is with format 'i915/glk_dmc_xxx', and the FW image name is with format 'i915_glk_dmc_xxx_bin'. But 'firmware_register' always registers FW with FW name but not FW image name, so 'lookup' FW by FW image name failed. Solution: always 'lookup' FW by FW name.
Diff Detail
Event TimelineComment Actions This seems questionable. Isn't the real problem where the firmware modules get created? Has anything changed recently (in Linux or there)? I am sure this will break other drivers. Comment Actions Same here. (Though the firmware does cause my i915 GPU to panic on the rare occasion, but that's a different problem.) Comment Actions How do you load the firmware? Comment Actions Let me describe the issue, and take 'i915_glk_dmc_ver1_04_bin.ko' firmware as an example: This issue is very easy to be reproduced. This fix only impacts the 'linuxkpi_request_firmware', if the fw name passed to linuxkpi_request_firmware is the same as the fwname passed to 'firmware_register', then no issue. Comment Actions I don't load the firmware, i915kms do it for me and it should also do it for you, can you share part of dmesg when you load i915kms without this patch ? Comment Actions Hi All, The 'request_firmware' and 'release_firmware' is NOT designed as Linux usage. I am still thinking about if there are better way to comptible Linux usage but don't break current FreeBSD logic. Comment Actions I suppose you understand what the root cause in my case. And share the dmesg: Sep 1 05:37:45 WT6C2B596A6985 kernel: [3.822448] iicbus3: <Philips I2C bus> on lkpi_iic1 Comment Actions That's the normal operation for i915kms, it loads the firmware, uploads it to the GPU and release it as it's not needed anymore.
Comment Actions No I really don't, it looks like you have a firmware with that name but that it contains crap data.
Comment Actions OK. If you look at the dmesg: '>> Sep 1 05:37:45 WT6C2B596A6985 kernel: [3.823367] i915_glk_dmc_ver1_04_bin: firmware image loaded, but did not register'. Why it reports this error, it is because fw is registered by the name "i915/glk_dmc_ver1_04.bin" while calling 'firmware_register', but the 'lookup' find the fw in table by the name 'i915_glk_dmc_ver1_04_bin', it is failed, so it reports this error. const struct firmware * unsigned int version, const struct firmware *parent) { /* We lost a race. */ mtx_unlock(&firmware_mtx); free(name, M_FIRMWARE); free(frp, M_FIRMWARE); return (NULL); } frp->parent = PRIV_FW(parent); LIST_INSERT_HEAD(&firmware_table, frp, link); printf("firmware: '%s' version %u: %zu bytes loaded at %p\n",
imagename, version, datasize, data);return (&frp->fw); const struct firmware * mtx_unlock(&firmware_mtx);
if (fp == NULL)
printf("%s: firmware image loaded, "
"but did not register\n", fwli->imagename);
(void) linker_release_module(fwli->imagename, NULL, NULL);
mtx_lock(&firmware_mtx);
goto done;}
Comment Actions If that's the error it would happend with all the firmwares that we provide, so I don't think that what you're saying is true.
Comment Actions
Do you mean the FW ko loaded -> upload to GPU -> unload FW ko, and if we do 'kldstat', the FW ko is not listed. Right? Comment Actions
OK. Let me confirm some facts:
Comment Actions https://github.com/freebsd/drm-kmod-firmware. I will try the latest one my tomorrow. Does it impact the naming? GLK is the intel chipset several year ago. Comment Actions Yes, all firmwares are named the same, see https://cgit.freebsd.org/ports/tree/graphics/gpu-firmware-intel-kmod/pkg-plist
Both ports and package (and also compiling the firmwares directly from https://github.com/freebsd/drm-kmod-firmware/) will install them in /boot/modules.
No, see https://dpaste.com/2VAAK6D6X
The i915kms driver will attempt to load i915/glk_dmc_ver1_04.bin but our compat code will change this path to a FreeBSD compatible one. Comment Actions To me this smells that the firmware is from before: Also manually copying the firmware seems weird. Why don't you just try to install the package using fwget and see what happens? Comment Actions Please test with a vanilla kernel and do pkg install drm-515-kmod gpu-firmware-intel-kmod-geminilake Comment Actions
Oh, it is clear now. Based on this piece of code, the firmware is registered with the name 'i915_glk_dmc_ver1_04_bin', but my debugging shows it be registered by the name 'i915/glk_dmc_ver1_04.bin'. Is this piece of code in FreeBSD source or is it in the firmware building source? How can I move to this code? Comment Actions It's generated code, you should never need to "move to this code" but if you want to see what's happening go to i915kmsfw/glkdmc_104 and make. Comment Actions I download the latest firmware soruce from https://github.com/freebsd/drm-kmod-firmware from master. Comment Actions
No. I mean where I can get the latestgpu fw source code just like github, and then I can build the fw kos by myself. Does FreeBSD have git repo for gpu fw, or from ports? Comment Actions https://github.com/freebsd/drm-kmod-firmware is the correct place, I was showing you that the firmware are correctly named when I build them, I don't know what you are doing wrong but clearly you're doing something wrong. Comment Actions ps://dpaste.com/CXTZE2TJY
Do you know how the C code been generated while making? Any scripts, or in which Makefile? I'd like to try change the registering name to the correct format. |