Page MenuHomeFreeBSD
Differential D41896

AM335x: ti_pinmux.c add pinconf-single to set of compatible strings
AbandonedPublic
Actions

Authored by oskar.holmlund_ohdata.se on Sep 17 2023, 3:31 PM.
Tags
Referenced Files
Unknown Object (File)
Dec 28 2023, 4:19 PM
Unknown Object (File)
Dec 13 2023, 4:10 AM
Unknown Object (File)
Dec 10 2023, 2:00 PM
Unknown Object (File)
Nov 30 2023, 7:09 AM
Unknown Object (File)
Nov 5 2023, 6:19 PM
Unknown Object (File)
Oct 11 2023, 12:44 PM
Unknown Object (File)
Oct 11 2023, 12:44 PM
Unknown Object (File)
Oct 10 2023, 6:18 PM
View All 10 Files
Subscribers
imp

Details

Reviewers
manu
karels
andrew
Summary

DTS import 5.16 changed am335x-pocketbeagle.dts to use pinconf-single instead of pinctrl-single.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

oskar.holmlund_ohdata.se created this revision.Sep 17 2023, 3:31 PM
Herald added a reviewer: andrew. · View Herald TranscriptSep 17 2023, 3:31 PM
Herald added a subscriber: imp. · View Herald Transcript
oskar.holmlund_ohdata.se requested review of this revision.Sep 17 2023, 3:31 PM
karels added a comment.Sep 17 2023, 4:18 PM

Seems fine to me, I could actually approve this one but I'll wait for others to take a look.

manu requested changes to this revision.Sep 18 2023, 7:23 AM

Since TI port is dead I think that this driver should be made generic and not patching it this way.
Both pinctrl-single and pinconf-single aren't specific for TI.

This revision now requires changes to proceed.Sep 18 2023, 7:23 AM
karels added a comment.Sep 18 2023, 12:24 PM
In D41896#954928, @manu wrote:

Since TI port is dead

I meant to ask, with the changes in the 3 reviews, and with a suitable config file, does TI now boot? E.g. BeagleBone Black?

oskar.holmlund_ohdata.se added a comment.Sep 19 2023, 8:00 AM

Manu: ok.

Mike, no you need more patches for it to boot. You will get it this week.
Beaglebone black boots with some u-boot issues regarding the ethernet and USB due to DTS missmatch to the one provided by Linux..
Pocketbeagle will not boot if you have a uboot version >= 2003.01.

karels added a comment.Sep 23 2023, 6:35 PM
In D41896#955137, @oskar.holmlund_ohdata.se wrote:

Mike, no you need more patches for it to boot. You will get it this week.
Beaglebone black boots with some u-boot issues regarding the ethernet and USB due to DTS missmatch to the one provided by Linux..
Pocketbeagle will not boot if you have a uboot version >= 2003.01.

Hopefully TI (incuding BBB) will boot in 14.0 with the u-boot and DTS in the release. Is that possible?

oskar.holmlund_ohdata.se mentioned this in D42015: AM335x: am335x_dmtpps remove possibility to use tunable just support FDT.Sep 28 2023, 7:14 PM
oskar.holmlund_ohdata.se abandoned this revision.Oct 9 2023, 6:31 PM

Replaced by D42124

Revision Contents
Changeset List

PathSize
sys/
arm/
ti/
8 lines

Diff 127478

View Options

sys/arm/ti/ti_pinmux.c

Loading...