Page MenuHomeFreeBSD
Differential D42389

ethernet: Reduce a runtime ntohs() in fast path
Needs ReviewPublic
Actions

Authored by zlei on Oct 28 2023, 7:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 16, 3:18 AM
Unknown Object (File)
Tue, Nov 12, 8:45 PM
Unknown Object (File)
Mon, Nov 11, 4:40 PM
Unknown Object (File)
Sun, Nov 10, 11:22 PM
Unknown Object (File)
Sat, Nov 9, 12:11 PM
Unknown Object (File)
Sat, Nov 9, 6:34 AM
Unknown Object (File)
Sat, Nov 9, 5:02 AM
Unknown Object (File)
Feb 8 2024, 11:39 PM
View All 14 Files
Subscribers
ae
cy
glebius
imp
melifaro

Details

Reviewers
None
Group Reviewers
network
Summary

For untagged traffic, we always hit the check for ether_type.

No functional change intended.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

zlei created this revision.Oct 28 2023, 7:13 PM
Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptOct 28 2023, 7:13 PM
zlei requested review of this revision.Oct 28 2023, 7:13 PM
zlei added inline comments.
sys/net/if_ethersubr.c
633

An extra space to improve readability.

melifaro added a comment.Oct 28 2023, 7:53 PM

I’d rather avoid doing that. ntohs is fast and branchless, so I’d vote for optimizing for readability here (unless there is a measurable performance gain)

zlei added a comment.Oct 28 2023, 8:06 PM
In D42389#967281, @melifaro wrote:

I’d rather avoid doing that.
ntohs is fast and branchless,

True indeed.

so I’d vote for optimizing for readability here (unless there is a measurable performance gain)

No measurable performance gain.

cy added a subscriber: cy.Oct 30 2023, 2:32 PM
In D42389#967281, @melifaro wrote:

I’d rather avoid doing that. ntohs is fast and branchless, so I’d vote for optimizing for readability here (unless there is a measurable performance gain)

Agrreed.

Revision Contents
Changeset List

PathSize
sys/
net/
11 lines

Diff 129482

View Options

sys/net/if_ethersubr.c

Loading...