Differential D42407

Stop using a temporary file for genoffset.sh
ClosedPublic
Actions

Authored by jtl on Oct 30 2023, 5:56 PM.

Details

Reviewers

imp

Commits

rGaccfb4cc9346: genoffset.sh: stop using a temporary file

Summary

Stop using a temporary file for genoffset.sh.

Instead, use a here document for the input. This allows us to run the while loop in the main script so we can build the list of asserts in a shell variable. We then print out the list of asserts at the end of the loop.

Test Plan

During a build, this produces the same results as the old version.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jtl requested review of this revision.Oct 30 2023, 5:56 PM

jtl created this revision.

I might also note in the commit message you used a here document with the shell output expanded in the commit message... it is a bit of a surprising change based on the commit message.

This revision is now accepted and ready to land.Oct 31 2023, 1:05 AM

jtl edited the summary of this revision. (Show Details)Nov 7 2023, 8:13 PM

In D42407#967685, @imp wrote:

I might also note in the commit message you used a here document with the shell output expanded in the commit message... it is a bit of a surprising change based on the commit message.

I took a stab at updating the commit message. Let me know if it looks better.

Update improved things.. Thanks!

Ship it please :-)

Closed by commit rGaccfb4cc9346: genoffset.sh: stop using a temporary file (authored by jtl). · Explain WhyNov 16 2023, 3:08 PM

This revision was automatically updated to reflect the committed changes.

jtl added a commit: rGaccfb4cc9346: genoffset.sh: stop using a temporary file.