Differential D42483

loader: improve lua ACPI detection and handling
ClosedPublic
Actions

Authored by rcm on Nov 6 2023, 5:31 PM.

Tags

Referenced Files

	Unknown Object (File)
	Sat, Nov 16, 7:11 PM

	Unknown Object (File)
	Sat, Nov 16, 7:07 PM

	Unknown Object (File)
	Fri, Nov 15, 1:28 PM

	Unknown Object (File)
	Thu, Nov 14, 6:46 PM

	Unknown Object (File)
	Thu, Nov 14, 6:14 PM

	Unknown Object (File)
	Mon, Nov 11, 1:52 PM

	Unknown Object (File)
	Mon, Nov 11, 4:05 AM

	Unknown Object (File)
	Mon, Nov 11, 3:28 AM

View All 26 Files

Subscribers

Details

Reviewers

imp
kevans
manu

Commits

rGe0f3dc82727f: loader: improve lua ACPI detection and handling

Summary

This is a follow-up patch to https://reviews.freebsd.org/D42459
that modifies the loader lua to use the correct loader variables
for determining ACPI availability. This also fixes a bug where
ACPI can be inadvertently disabled when setting System Defaults
at the loader menu.

Sponsored By: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rcm created this revision.Nov 6 2023, 5:31 PM

Herald added a reviewer: manu. · View Herald TranscriptNov 6 2023, 5:31 PM

Herald added a subscriber: dab. · View Herald Transcript

rcm requested review of this revision.Nov 6 2023, 5:31 PM

looks good now. Thanks for the split.

This revision is now accepted and ready to land.Nov 6 2023, 6:39 PM

Just one minor nit

stand/lua/core.lua.8
110	New sentence should begin on new line

rcm updated this revision to Diff 129791.Nov 6 2023, 7:01 PM

This revision now requires review to proceed.Nov 6 2023, 7:01 PM

rcm marked an inline comment as done.Nov 6 2023, 7:01 PM

rcm added inline comments.

stand/lua/core.lua.8
110	Fixed.

rcm marked an inline comment as done.Nov 6 2023, 7:02 PM

kevans accepted this revision.Nov 17 2023, 9:37 PM

This revision is now accepted and ready to land.Nov 17 2023, 9:37 PM

Closed by commit rGe0f3dc82727f: loader: improve lua ACPI detection and handling (authored by rcm). · Explain WhyNov 20 2023, 7:06 PM

This revision was automatically updated to reflect the committed changes.

rcm added a commit: rGe0f3dc82727f: loader: improve lua ACPI detection and handling.

Revision Contents
Changeset List

Path

Size

stand/

lua/

39 lines

24 lines

2 lines

Diff 130345

stand/lua/core.lua

Loading...

stand/lua/core.lua.8

Loading...

stand/lua/menu.lua

Loading...