Paths

Table of Contentst

Differential D43289

graphics/inkscape: update to 1.3.2
ClosedPublic
Actions

Authored by vvd on Jan 3 2024, 2:00 AM.

Tags

Referenced Files

	Unknown Object (File)
	Fri, Nov 29, 11:50 AM

	Unknown Object (File)
	Thu, Nov 28, 1:02 PM

	Unknown Object (File)
	Wed, Nov 20, 11:21 PM

	Unknown Object (File)
	Thu, Nov 14, 11:21 PM

	Unknown Object (File)
	Tue, Nov 12, 2:21 PM

	Unknown Object (File)
	Tue, Nov 12, 11:39 AM

	Unknown Object (File)
	Sat, Nov 9, 11:47 AM

	Unknown Object (File)
	Fri, Nov 8, 6:47 PM

View All 27 Files

Subscribers

Details

Reviewers

tcberner
arrowd
adamw

Group Reviewers

Commits

R11:0d48bd601192: graphics/inkscape: update to 1.3.2
R11:e9c31503dda1: graphics/inkscape: update to 1.3.2

Summary

Update to 1.3.2: https://gitlab.com/inkscape/inkscape/-/releases

https://inkscape.org/news/2023/11/18/big-small-release-inkscape-131-is-out/
https://inkscape.org/news/2023/12/01/Inkscape-1-3-2-solves-data-loss-bug/

Removed unused dependencies (make stage-qa).
Replaced dependency from print/scribus-devel 1.5.8 to print/scribus 1.6.0.
Tested build in poudriere and on live system 13.2-p9 amd64.
Tested run on 13.2-p9 amd64.

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

vvd requested review of this revision.Jan 3 2024, 2:00 AM

vvd created this revision.

vvd updated this revision to Diff 132173.Jan 3 2024, 2:02 AM

I haven't tested it, but the patch looks good. When you're happy with the tests, go for it.

This revision is now accepted and ready to land.Jan 3 2024, 11:06 AM

vvd added a subscriber: kwm.Jan 3 2024, 2:43 PM

kwm@, can you please help with USES "iconv:wchar_t"/"iconv" - you added it in commit https://cgit.freebsd.org/ports/commit/?id=36b017c5ac6549ffa2431727f6f095fcbdf705ad
and in commit https://cgit.freebsd.org/ports/commit/?id=0bebae225ad1901ebffa99412280f31336255319
Do we need it now?
It build and run fine, but I don't know how to test this.

vishwin added a subscriber: vishwin.Jan 4 2024, 3:28 AM

vishwin added inline comments.

graphics/inkscape/Makefile
33	why?

vvd added inline comments.Jan 4 2024, 12:48 PM

graphics/inkscape/Makefile
33	stage-qa said "Warning: you might not need LIB_DEPENDS on libpng.so" and after remove it "Error" message that it link with libpng16.so.

In D43289#986754, @vvd wrote:

kwm@, can you please help with USES "iconv:wchar_t"/"iconv" - you added it in commit https://cgit.freebsd.org/ports/commit/?id=36b017c5ac6549ffa2431727f6f095fcbdf705ad
and in commit https://cgit.freebsd.org/ports/commit/?id=0bebae225ad1901ebffa99412280f31336255319
Do we need it now?
It build and run fine, but I don't know how to test this.

Good question, I think it was because clang and/or libc++ or whatever we used back then didn't want to compile without that flag.

I would say that if inkscape builds and runs fine without it to just leave it out.

vvd updated this revision to Diff 132353.Jan 5 2024, 9:39 PM

This revision now requires review to proceed.Jan 5 2024, 9:39 PM

Thanks!

MFH: 2024Q1 - a lot of crash/freeze/bug fixes.

I'll commit in several minutes.

graphics/inkscape/Makefile
33	Reverted to `libpng.so` (from `libpng16.so`).

This revision was not accepted when it landed; it landed in state Needs Review.Jan 5 2024, 9:50 PM

Closed by commit R11:e9c31503dda1: graphics/inkscape: update to 1.3.2 (authored by vvd). · Explain Why

This revision was automatically updated to reflect the committed changes.

vvd added a commit: R11:e9c31503dda1: graphics/inkscape: update to 1.3.2.

vvd added a commit: R11:0d48bd601192: graphics/inkscape: update to 1.3.2.Jan 5 2024, 10:01 PM

Revision Contents
Changeset List

Path

Size

graphics/

inkscape/

14 lines

8 lines

5 lines

Diff 132354

graphics/inkscape/Makefile

Loading...

graphics/inkscape/distinfo

Loading...

graphics/inkscape/pkg-plist

Loading...