periodic: Fix periodic reports when log files are not compressed.
The modern zcat(1) is capable of handling compressed and uncompressed
text files, so we can simply use zcat command.
PR: 253168
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
This is fine...
But maybe that function needs to be in a central location?
rc.subr seems the only place that might be accessible because periodic doesn't have a set of common routines, though there's a few in periodic.conf
Moving catmsgs likely should be considered, but might be out of scope for such a simple fix.
Comment Actions
I don't think these whole case..esac blocks are needed: modern enough zcat(1) is capable of handling compressed and uncompressed text files, so you can simply do:
do zcat -f $f done
and done with it...
This is already implemented in zcat(1) :)
Comment Actions
LGTM. Do we want to extract that catmsgs out to somewhere? (Not necessarily as part of this commit)