Added '-w' to enable forwarding of these events follows.
Used checkstyle9.pl to fix also some style in this code.
Sponsored by: Modirum MDPay
Sponsored by: Klara, Inc.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 56449 Build 53337: arc lint + arc unit
Event Timeline
| usr.bin/script/script.c | ||
|---|---|---|
| 79 | Prevailing style in this file seems to be to dropping the explicit initialization, it'll be in .bss anyways | |
| 97 | Consistency again- drop the name of the parameter | |
| 115 | This should probably go up with win and whatnot, to maintain some semblance of the current size-descending -ish ordering | |
| 309 | I'm wondering if there's a way for this to fail; might be better to error-check it, just to avoid TIOCWINSZ with a potentially bogus win? It may not hae actually been initialized earlier if stdin isn't a tty, though I wonder now if you can hit that scenario *and* get a SIGWINCH somewhere in there. Not suggesting doing anything with the error, just only doing the TIOCSWINSZ call if this one returned != -1 | |
Comment Actions
Do initialization of variables in main().
Renamed the fuction onsigwinch() into resizeit().
Check if return -1 before doing the next ioctl.
| usr.bin/script/script.c | ||
|---|---|---|
| 309 | ||
Comment Actions
Variable names consitency.
Move do_resize=0 out of the if to avoid trying resize. May fail one time instead of always.
| usr.bin/script/script.c | ||
|---|---|---|
| 97 | Right... Sorry | |
| usr.bin/script/script.c | ||||
|---|---|---|---|---|
| 127 | These still needed? The comment is lame anyway... no version, no reason, no deeper explanation.... I know you're just fixing the style, but did you try it w/o the init? It's likely for gcc 4 at this point. | |||
| 288 |
Or do window changes not fire select? | |||
| 308 | is a 1 second latency sufficient? See above... | |||
| usr.bin/script/script.c | ||
|---|---|---|
| 288 | I don't believe they do; in the common case you're probably inside select(2) and you get smacked with an EINTR after returning from the signal handler. You could perhaps block SIGWINCH and then switch to pselect(2) to unblock it and reliably interrupt it. | |
| usr.bin/script/script.c | ||
|---|---|---|
| 127 | I don't know, is there any architecture supported by FreeBSD that use gcc for building ? (sorry for the stupid question indeed). | |