User Details
User Details
- User Since
- Apr 9 2015, 9:27 PM (600 w, 5 d)
Today
Today
Yesterday
Yesterday
Sun, Oct 11
Sun, Oct 11
Jul 5 2026
Jul 5 2026
Jun 21 2026
Jun 21 2026
Jun 19 2026
Jun 19 2026
May 18 2026
May 18 2026
May 13 2026
May 13 2026
May 7 2026
May 7 2026
May 5 2026
May 5 2026
Apr 22 2026
Apr 22 2026
Apr 13 2026
Apr 13 2026
Apr 10 2026
Apr 10 2026
Apr 7 2026
Apr 7 2026
Apr 6 2026
Apr 6 2026
Jan 15 2026
Jan 15 2026
Jan 11 2026
Jan 11 2026
Jan 10 2026
Jan 10 2026
Dec 19 2025
Dec 19 2025
sjg added inline comments to D54291: Makefile.inc1: Make NO_INSTALLKERNEL less of a hack.
Dec 18 2025
Dec 18 2025
sjg added inline comments to D54291: Makefile.inc1: Make NO_INSTALLKERNEL less of a hack.
Dec 10 2025
Dec 10 2025
Dec 9 2025
Dec 9 2025
sjg requested review of D54150: Update share/mk files from bmake.
Dec 7 2025
Dec 7 2025
Dec 3 2025
Dec 3 2025
Nov 30 2025
Nov 30 2025
Nov 26 2025
Nov 26 2025
Nov 24 2025
Nov 24 2025
Nov 18 2025
Nov 18 2025
sjg added inline comments to D53790: Centralize definition of ZFSTOP.
Nov 1 2025
Nov 1 2025
Oct 30 2025
Oct 30 2025
sjg requested review of D53476: rc.subr set dot_dir and dot_file in dot.
Oct 29 2025
Oct 29 2025
sjg added inline comments to D53429: style.Makefile: document the style for lists.
Sep 18 2025
Sep 18 2025
sjg added a comment to D52563: bmake: Fix -Wunterminated-string-initialization.
Perfect, thank you. Should I wait for this to find it's way to FreeBSD or apply the change locally?
Sep 16 2025
Sep 16 2025
sjg added a comment to D52563: bmake: Fix -Wunterminated-string-initialization.
No need for a comment, I committed the following upstream:
Index: var.c =================================================================== RCS file: /cvsroot/src/usr.bin/make/var.c,v retrieving revision 1.1171 diff -u -p -r1.1171 var.c --- var.c 29 Jun 2025 11:02:17 -0000 1.1171 +++ var.c 16 Sep 2025 15:13:28 -0000 @@ -1850,7 +1850,7 @@ QuoteShell(const char *str, bool quoteDo static char * Hash(const char *str) { - static const char hexdigits[16] = "0123456789abcdef"; + static const char hexdigits[] = "0123456789abcdef"; const unsigned char *ustr = (const unsigned char *)str;
Sep 15 2025
Sep 15 2025
Sep 8 2025
Sep 8 2025
sjg added inline comments to D52420: crypto/openssl: apply polish to new vendor import process.
Aug 21 2025
Aug 21 2025
sjg added a comment to D52060: Stub is_tftp when LOADER_NET_SUPPORT is not enabled.
In case it isn't obvious, we can't stub or #ifdef this in libsa since that is presumably shared by all loaders for a given arch, thus a non-optional src from loader.mk would seem to make sense - misc.c seemed as good as any?
sjg requested review of D52060: Stub is_tftp when LOADER_NET_SUPPORT is not enabled.
Aug 20 2025
Aug 20 2025
Aug 8 2025
Aug 8 2025
Aug 7 2025
Aug 7 2025
Aug 5 2025
Aug 5 2025
Aug 1 2025
Aug 1 2025
sjg updated the diff for D51187: Allow secure-netboot.
Split out fs_ops.fs_flag to D51684
sjg requested review of D51684: stand: add fs_ops.fs_flag.
Jul 30 2025
Jul 30 2025
sjg added a comment to D51443: release/Makefile should not use the host /usr/bin/install command, but the freshly built one.
Jul 25 2025
Jul 25 2025
works for me, just one nit above
sjg added a comment to D50149: do not commit - bmake: add a package for bmake and share/mk.
Note I would disagree that make isn't needed in a minimal install, I use make and makefiles for all sorts of use-cases that have nothing to do with building src/
Jul 24 2025
Jul 24 2025
sjg added inline comments to D51490: bsd.man.mk: add MANGROUPS.
Jul 23 2025
Jul 23 2025
sjg updated the diff for D51447: loader: do not try to mount currdev for TFTP.
Rework to avoid opening dirs via TFTP while not breaking diskless
boot with nfs.
sjg accepted D51467: security/ossec-hids-local: fix makefile warnings: Invalid character " " in variable name.
I can't approved, but looks sane - I assume it works ;-)
Jul 22 2025
Jul 22 2025
sjg added inline comments to D51447: loader: do not try to mount currdev for TFTP.
Jul 21 2025
Jul 21 2025
sjg requested review of D51454: bsd.subdir.mk skip _SUBDIR for DIRDEPS_BUILD.
