Page MenuHomeFreeBSD

libgcc_s: only export 128-bit int APIs when available
AcceptedPublic

Authored by brooks on Mar 12 2024, 9:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 6:27 AM
Unknown Object (File)
Tue, Nov 12, 6:06 PM
Unknown Object (File)
Mon, Nov 11, 12:13 PM
Unknown Object (File)
Mon, Nov 11, 5:59 AM
Unknown Object (File)
Sun, Nov 10, 1:21 PM
Unknown Object (File)
Sat, Nov 9, 6:09 PM
Unknown Object (File)
Fri, Nov 8, 12:22 PM
Unknown Object (File)
Apr 10 2024, 7:11 PM
Subscribers

Details

Summary

These interfaces are only compiled when the platform supports 128-bit
ints. Use a CRT_HAS_128BIT guard similar to the one used in the
compiler_rt sources.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 56558
Build 53446: arc lint + arc unit

Event Timeline

Hm, are these files automagically pulled through a preprocessor? I wasn't aware of that... but yeah, then it is probably a good idea.

This revision is now accepted and ready to land.Mar 12 2024, 9:26 PM
In D44323#1011003, @dim wrote:

Hm, are these files automagically pulled through a preprocessor? I wasn't aware of that... but yeah, then it is probably a good idea.

Somewhat confusingly we have two mechanisms. We have SYMBOL_MAPS where they are preprocessed and then combined with Versions.def to create a version map which a few libraries like libcxxrt use directly. The latter format uses # comments so can't be preprocessed.