Page MenuHomeFreeBSD

mpi3r: Track IO per target counter during queue poll with local var
AcceptedPublic

Authored by chandrakanth.patil_broadcom.com on Mar 25 2024, 6:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 5:37 PM
Unknown Object (File)
Thu, Nov 21, 11:10 AM
Unknown Object (File)
Mon, Nov 11, 12:54 PM
Unknown Object (File)
Sat, Nov 9, 5:00 AM
Unknown Object (File)
Sat, Nov 9, 3:54 AM
Unknown Object (File)
Fri, Nov 8, 12:47 PM
Unknown Object (File)
Fri, Nov 8, 1:43 AM
Unknown Object (File)
Mar 28 2024, 2:06 AM
Subscribers
None

Details

Summary

Use a local variable to fetch the value of "target->outstanding" once, and then utilize this same value both in the if condition
and when printing its value. This ensures consistency and avoids potential differences due to multiple reads. Additionally, add a
space between the %d format specifier and strings in the next line.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Change looks good, but you'll want to edit the 'subject' of the commit message to be < 70 characters

This revision is now accepted and ready to land.Mar 25 2024, 10:25 AM
chandrakanth.patil_broadcom.com retitled this revision from mpi3r: Use a local variable for retrieving the IO outstanding counter per target when polling the reply queue to mpi3r: Track IO per target counter during queue poll with local var.Mar 25 2024, 5:37 PM
In D44494#1014836, @imp wrote:

Change looks good, but you'll want to edit the 'subject' of the commit message to be < 70 characters

It is done. I have reduced the headline to <70 characters.