ctl: Add assertions in SCSI-only paths
ClosedPublic
Actions

Authored by jhb on Apr 18 2024, 5:48 PM.

Details

Reviewers

imp
ken

Group Reviewers

cam

Commits

rG105333f1d6ee: ctl: Add assertions in SCSI-only paths

Summary

Assert that only SCSI I/O requests are passed in various places
that assume a SCSI I/O request (that is, places that access fields
in io->scsiio directly).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 57506
Build 54394: arc lint + arc unit

Event Timeline

jhb created this revision.Apr 18 2024, 5:48 PM

Herald added a reviewer: cam. · View Herald TranscriptApr 18 2024, 5:48 PM

jhb requested review of this revision.Apr 18 2024, 5:48 PM

Harbormaster completed remote builds in B57186: Diff 137325.Apr 18 2024, 5:48 PM

jhb added a parent revision: D44846: ctl: Update some core data paths to be protocol agnostic.Apr 18 2024, 5:48 PM

jhb added a child revision: D44720: ctl: Support for NVMe commands.Apr 18 2024, 5:49 PM

Update for CTL_IO_ASSERT macro

Harbormaster completed remote builds in B57506: Diff 137970.May 1 2024, 8:30 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 3 2024, 12:16 AM

Closed by commit rG105333f1d6ee: ctl: Add assertions in SCSI-only paths. · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG105333f1d6ee: ctl: Add assertions in SCSI-only paths.

Revision Contents
Changeset List

Path

Size

sys/

cam/

ctl/

ctl.c

45 line(s)

Diff 137970

View Options

ctl: Add assertions in SCSI-only pathsClosedPublicActions