Add accessor methods to fetch the BAR holding the MSI-X table and PBA.
While here, explicitly note the requirement that the BAR(s) must be
allocated prior to calling pci_alloc_msix().
Details
Details
- Reviewers
emaste andrew - Group Reviewers
manpages - Commits
- rS292669: Add accessor methods to fetch the BAR holding the MSI-X table and PBA.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| share/man/man9/pci.9 | ||
|---|---|---|
| 711 ↗ | (On Diff #11616) | Yeah, I was torn writing it. I think it's because I was taught to always spell out single digit numbers in English and only resort to numerals for larger values. However, we use -1 in other manpages so I will change it. |
Comment Actions
- Add accessor methods to fetch the BAR holding the MSI-X table and PBA.
- Use -1 instead of "negative one".
| share/man/man9/pci.9 | ||
|---|---|---|
| 711 ↗ | (On Diff #11618) | Yeah, for standard prose that's a useful style guide rule, but IMHO when we're referring explicitly to an argument or return value it should use numerals. For example These three functions return 0, 1 or -1. |
Comment Actions
You may wish to point out the value returned can be used as the resource id when mapping the configuration space. That was the only thing that tripped me up adding this to the xhci driver.