IfAPI: hide struct ifaddr from if_foreach_addr_type() callbacks
Needs ReviewPublic
Actions

Authored by glebius on Dec 12 2024, 2:12 PM.

Details

Reviewers

bz
jhibbits

Group Reviewers

network
Restricted Owners Package	(Owns No Changed Paths)

Summary

struct ifaddr is an internal structure, just like ifnet. The IfAPI
should keep it opaque from drivers.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61112
Build 57996: arc lint + arc unit

Event Timeline

glebius created this revision.Dec 12 2024, 2:12 PM

Owners added a reviewer: Restricted Owners Package.Dec 12 2024, 2:12 PM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptDec 12 2024, 2:12 PM

glebius requested review of this revision.Dec 12 2024, 2:12 PM

Harbormaster completed remote builds in B61112: Diff 147857.Dec 12 2024, 2:12 PM

glebius added a parent revision: D48053: xen/netfront: use iflladdr_event to send ARPs.Dec 12 2024, 2:12 PM

ehem_freebsd_m5p.com mentioned this in D48053: xen/netfront: use iflladdr_event to send ARPs.Dec 12 2024, 9:33 PM

LGTM but let me ask @bartosz.sobczak_intel.com to take a look at irdma changes.

In D48054#1101622, @krzysztof.galazka_intel.com wrote:

LGTM but let me ask @bartosz.sobczak_intel.com to take a look at irdma changes.

Thanks! This is the part I can't test, so will really appreciate.

In D48054#1101719, @glebius wrote:

In D48054#1101622, @krzysztof.galazka_intel.com wrote:

LGTM but let me ask @bartosz.sobczak_intel.com to take a look at irdma changes.

Thanks! This is the part I can't test, so will really appreciate.

Visually looks fine. let us run a test or two.

jhibbits accepted this revision.Feb 9 2025, 5:12 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linux/

linux.c

4 line(s)

linux_ioctl.c

5 line(s)

dev/

irdma/

fbsd_kcompat.c

16 line(s)

irdma_cm.h

1 line

irdma_cm.c

13 line(s)

qlnx/

qlnxr/

qlnxr_os.c

6 line(s)

net/

if.c

2 line(s)

if_var.h

2 line(s)

nfs/

bootp_subr.c

4 line(s)

ofed/

drivers/

infiniband/

core/

ib_roce_gid_mgmt.c

46 line(s)

ulp/

ipoib/

ipoib_main.c

6 line(s)

include/

rdma/

ib_addr.h

5 line(s)

Diff 147857

View Options

sys/compat/linux/linux.c

View Options

sys/compat/linux/linux_ioctl.c

View Options

sys/dev/irdma/fbsd_kcompat.c

View Options

sys/dev/irdma/irdma_cm.h

View Options

sys/dev/irdma/irdma_cm.c

View Options

sys/dev/qlnx/qlnxr/qlnxr_os.c

View Options

sys/net/if.c

View Options

sys/net/if_var.h

View Options

sys/nfs/bootp_subr.c

View Options

sys/ofed/drivers/infiniband/core/ib_roce_gid_mgmt.c

View Options

sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_main.c

View Options

sys/ofed/include/rdma/ib_addr.h

IfAPI: hide struct ifaddr from if_foreach_addr_type() callbacksNeeds ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 147857

sys/compat/linux/linux.c

sys/compat/linux/linux_ioctl.c

sys/dev/irdma/fbsd_kcompat.c

sys/dev/irdma/irdma_cm.h

sys/dev/irdma/irdma_cm.c

sys/dev/qlnx/qlnxr/qlnxr_os.c

sys/net/if.c

sys/net/if_var.h

sys/nfs/bootp_subr.c

sys/ofed/drivers/infiniband/core/ib_roce_gid_mgmt.c

sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_main.c

sys/ofed/include/rdma/ib_addr.h

IfAPI: hide struct ifaddr from if_foreach_addr_type() callbacks
Needs ReviewPublic
Actions

Revision Contents
Changeset List