Page MenuHomeFreeBSD
Differential D4920

Hyperv: Event handling code refactor.
ClosedPublic
Actions

Authored by howard0su_gmail.com on Jan 13 2016, 8:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 17 2024, 9:02 AM
Unknown Object (File)
Feb 13 2024, 7:06 AM
Unknown Object (File)
Feb 13 2024, 2:48 AM
Unknown Object (File)
Feb 12 2024, 9:58 PM
Unknown Object (File)
Dec 25 2023, 7:32 AM
Unknown Object (File)
Dec 25 2023, 7:32 AM
Unknown Object (File)
Dec 25 2023, 7:32 AM
Unknown Object (File)
Dec 25 2023, 7:32 AM
View All Files
Subscribers
imp

Details

Reviewers
honzhan_microsoft.com
decui_microsoft.com
delphij
sepherosa_gmail.com
royger
adrian
Commits
rS294886: hyperv/vmbus: Event handling code refactor.
Summary
  1. use taskqueue instead of swi
  2. scan the interrupt flags in filter
  3. disable ringbuffer interrupt mask in filter to ensure no unnecessary interrupts

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

howard0su_gmail.com updated this revision to Diff 12251.Jan 13 2016, 8:39 AM
howard0su_gmail.com retitled this revision from to Hyperv: Event handling code refactor..
howard0su_gmail.com updated this object.
howard0su_gmail.com edited the test plan for this revision. (Show Details)
howard0su_gmail.com added a reviewer: decui_microsoft.com.
howard0su_gmail.com set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptJan 13 2016, 8:39 AM
howard0su_gmail.com added a parent revision: D4802: hyperv: vmbus: Optimize channel lookup through id through a map table.Jan 13 2016, 8:40 AM
howard0su_gmail.com updated this revision to Diff 12257.Jan 13 2016, 12:51 PM

drain and free taskqueue.

howard0su_gmail.com added reviewers: delphij, royger, honzhan_microsoft.com, sepherosa_gmail.com.Jan 14 2016, 2:24 AM
sepherosa_gmail.com edited edge metadata.Jan 14 2016, 3:31 AM

Does this mean, you are going to have at least one taskq, i.e. one thread, per-device? I think its probably too excessive for the already slow VM.

howard0su_gmail.com added a comment.Jan 14 2016, 3:43 AM
In D4920#104502, @sepherosa_gmail.com wrote:

Does this mean, you are going to have at least one taskq, i.e. one thread, per-device? I think its probably too excessive for the already slow VM.

Yes. We can use taskqueue_swi instead creating another queue for each channel. but i noticed most NIC driver is using this approach. so I use the same way here.

sepherosa_gmail.com added a comment.Jan 14 2016, 3:49 AM
In D4920#104503, @howard0su_gmail.com wrote:
In D4920#104502, @sepherosa_gmail.com wrote:

Does this mean, you are going to have at least one taskq, i.e. one thread, per-device? I think its probably too excessive for the already slow VM.

Yes. We can use taskqueue_swi instead creating another queue for each channel. but i noticed most NIC driver is using this approach. so I use the same way here.

Well, as I said, I think its an overkill to have a taskq per-channel. How about just replace the swi you removed in this patch w/ a taskq instead.

howard0su_gmail.com updated this revision to Diff 12315.Jan 14 2016, 2:25 PM
howard0su_gmail.com edited edge metadata.

Create taskqueue per CPU instead of per channel

sepherosa_gmail.com added a comment.Jan 15 2016, 1:34 AM

Looks good to me

sys/dev/hyperv/vmbus/hv_vmbus_drv_freebsd.c
498 ↗(On Diff #12315)

M_WAITOK here? We don't want it to fail

sepherosa_gmail.com added a reviewer: adrian.Jan 15 2016, 1:34 AM
adrian accepted this revision.Jan 15 2016, 1:36 AM
adrian edited edge metadata.
This revision is now accepted and ready to land.Jan 15 2016, 1:36 AM
howard0su_gmail.com updated this revision to Diff 12352.Jan 15 2016, 7:12 AM
howard0su_gmail.com edited edge metadata.

address review comments

This revision now requires review to proceed.Jan 15 2016, 7:12 AM
adrian accepted this revision.Jan 15 2016, 7:13 AM
adrian edited edge metadata.
This revision is now accepted and ready to land.Jan 15 2016, 7:13 AM
decui_microsoft.com accepted this revision.Jan 17 2016, 8:14 AM
decui_microsoft.com edited edge metadata.

LGTM

sys/dev/hyperv/vmbus/hv_vmbus_drv_freebsd.c
527 ↗(On Diff #12352)

Typo: ahdnle --> handle.

howard0su_gmail.com updated this revision to Diff 12384.Jan 17 2016, 1:01 PM
howard0su_gmail.com edited edge metadata.
howard0su_gmail.com marked an inline comment as done.

Fix typo in comment

This revision now requires review to proceed.Jan 17 2016, 1:01 PM
howard0su_gmail.com added a comment.Jan 23 2016, 2:38 AM

iperf result shows no performance regression after this change.

howard0su_gmail.com updated this revision to Diff 12704.Jan 26 2016, 4:32 AM
howard0su_gmail.com edited edge metadata.

Rebase to current

adrian accepted this revision.Jan 26 2016, 4:35 AM
adrian edited edge metadata.
This revision is now accepted and ready to land.Jan 26 2016, 4:35 AM
howard0su_gmail.com added a child revision: D5081: Remove NOWAIT in the places where actually can wait..Jan 27 2016, 2:35 AM
Closed by commit rS294886: hyperv/vmbus: Event handling code refactor. (authored by sephe). · Explain WhyJan 27 2016, 3:53 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
hyperv/
include/
2 lines
vmbus/
74 lines
79 lines
49 lines
5 lines

Diff 12739

View Options

head/sys/dev/hyperv/include/hyperv.h

Loading...
View Options

head/sys/dev/hyperv/vmbus/hv_channel.c

Loading...
View Options

head/sys/dev/hyperv/vmbus/hv_connection.c

Loading...
View Options

head/sys/dev/hyperv/vmbus/hv_vmbus_drv_freebsd.c

Loading...
View Options

head/sys/dev/hyperv/vmbus/hv_vmbus_priv.h

Loading...