The coherent busdma implementation doesn't need to set DMAMAP_COHERENT.
It is only used in cacheline_bounce which is unused there.
Sponsored by: Arm Ltd
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 63184 Build 60068: arc lint + arc unit
Event Timeline
| sys/arm64/arm64/busdma_bounce.c | ||
|---|---|---|
| 105 | Why is DMAMAP_COHERENT being renamed here? This seems an okay idea, but if you're going to rename all the other uses should also be modified. Yet instead you have the new #define below so this doesn't seem useful as you've got a halfway done job. | |
| 364–368 | Since both of these are now single-line, I would remove the brackets while you're at it. | |