Paths

Table of Contentst

Differential D49810

linuxkpi: Move `release_pages()` to linux_page.c
ClosedPublic
Actions

Authored by dumbbell on Apr 13 2025, 11:27 AM.

Details

Reviewers

markj

Group Reviewers

linuxkpi

Commits

rGe51729f608da: linuxkpi: Move `release_pages()` to linux_page.c

Summary

We want to avoid putting code managing memory in inline functions in the future.

This is part of the update of DRM drivers to Linux 6.7. This is a follow-up to D48743.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dumbbell created this revision.Apr 13 2025, 11:27 AM

Herald added subscribers: emaste, imp. · View Herald TranscriptApr 13 2025, 11:27 AM

dumbbell requested review of this revision.Apr 13 2025, 11:27 AM

dumbbell added a reviewer: markj.

dumbbell mentioned this in D48743: linuxkpi: Add `folio` and `folio_batch` APIs.Apr 13 2025, 11:37 AM

wulf subscribed.Apr 13 2025, 2:47 PM

wulf added inline comments.

sys/compat/linuxkpi/common/src/linux_page.c
180	Please add lkpi_ or linuxkpi_ prefix with corresponding #define to not pollute namespace

Rename release_pages() to linux_release_pages() to address @wulf concern.

dumbbell mentioned this in D49811: linuxkpi: Move `put_page()` closer to `get_page()`.Apr 14 2025, 6:58 PM

markj accepted this revision.Apr 15 2025, 1:38 PM

This revision is now accepted and ready to land.Apr 15 2025, 1:38 PM

dumbbell marked an inline comment as done.May 8 2025, 9:25 AM

Closed by commit rGe51729f608da: linuxkpi: Move `release_pages()` to linux_page.c. · Explain WhyMay 12 2025, 5:47 PM

This revision was automatically updated to reflect the committed changes.

dumbbell added a commit: rGe51729f608da: linuxkpi: Move `release_pages()` to linux_page.c.

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

mm.h

2 line(s)

pagemap.h

9 line(s)

src/

linux_page.c

9 line(s)

Diff 153607

View Options

sys/compat/linuxkpi/common/include/linux/mm.h

View Options

sys/compat/linuxkpi/common/include/linux/pagemap.h

View Options

sys/compat/linuxkpi/common/src/linux_page.c

linuxkpi: Move `release_pages()` to linux_page.c ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 153607

sys/compat/linuxkpi/common/include/linux/mm.h

sys/compat/linuxkpi/common/include/linux/pagemap.h

sys/compat/linuxkpi/common/src/linux_page.c

linuxkpi: Move `release_pages()` to linux_page.c
ClosedPublic
Actions

Revision Contents
Changeset List