Differential D49818
net80211: move the storing of ni in the mbuf further down Authored by bz on Apr 13 2025, 11:13 PM.
Details
We store the node (ni) in the mbuf meta data already after Sponsored by: The FreeBSD Foundation
Diff Detail
Event TimelineComment Actions Is that true though? like, the superg/amsdu transmit path is also queuing the packet and it needs the node reference for it to do so. Comment Actions Sugar. And ff_transmit() has the same problem that it might lose it and then we go kaboom in ieee80211_parent_xmitpkt error case; okay; there's also an improvement to be had there. I'll do the other one first and revise this. I think the answer is to audit ieee80211_encap callers and if all do the same make sure ieee80211_encap preserves the meta information. Comment Actions Yeah, let's both do that (some auditing/review) first. My earlier diff on documenting the transmit paths at least document the node ref stuff, I can also go document the encap behaviour too in another diff. |