rtwn: enable seqno offload
AbandonedPublic
Actions

sys/dev/rtwn/rtl8192c/r92c_tx.c
458	See comment for r12a_tx.c
sys/dev/rtwn/rtl8812a/r12a_tx.c
439	why is this one not having the % IEEE80211_SEQ_RANGE ? I think it really wants to use ieee80211_tx_seqno_fetch_incr()

This revision now requires changes to proceed.Aug 19 2025, 7:32 PM

adrian added inline comments.Aug 24 2025, 1:11 AM

sys/dev/rtwn/rtl8812a/r12a_tx.c
439	I'll experiment with that later. I need to do some more experiments with rtwn with and without firmware - eg i think with firmware its handling stuff like NULL QoS frames and doing power save stuff in general, but without firmware we'd have to do it in net80211.

I cleaned up the seqno assignment stuff in D52301 and D52302. In particular after D52302, we can sweep the drivers and remove the "% IEEE80211_SEQ_RANGE" because, well, it's now done in the macro.

bz mentioned this in D52301: [rtwn] Migrate to use ieee80211_output_seqno_assign().Sep 1 2025, 1:11 AM

I've tested these with the suggested changes / questions and it works fine, so I'll clean up the diffs tonight and land em. Thanks bz!

👍 Still think you want to squash this one into D52301 or reduce this to the simple "enable offload" as the other functional changes are cleaned up already in D52301

adrian mentioned this in rGdff11c4f8007: rtwn: enable seqno offload; migrate to use ieee80211_output_seqno_assign().Sep 6 2025, 6:25 AM