Take the condition of RFC 6675 into account. While there, remove stale comments.
Details
Details
- Reviewers
rscheff peter.lei_ieee.org cc rrs lstewart - Group Reviewers
transport - Commits
- rG2b5de4330ee1: tcp: improve the condition for detecting dup ACKs
Will provide some packetdrill tests.
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| sys/netinet/tcp_input.c | ||
|---|---|---|
| 2605–2606 | Can wrap these two lines into a single line now. | |
| 2680–2681 | Can wrap these two lines into a single line now. | |
| 2720–2722 | Looks like dead code to me, as here should be "th->th_ack == tp->snd_una". | |
| 2810 | * counter as per RFC 6675. The variable <== one extra space I think a better read can be: | |
Comment Actions
Thanks for the following improvements:
- put the checks of "non-DUP-ACK" first
- remove one tab indent
- remove some dead code and the resume_partialack label
- clear comments between line# [2597, 2633]
- make sure advancing ACKs are counted as DUP-ACKs under the V_tcp_do_newsack toggle
Some minor clean-ups remain. I am good with this change.
| sys/netinet/tcp_input.c | ||
|---|---|---|
| 2801–2802 | Do you mean this minor change for readability? KASSERT(SEQ_GT(th->th_ack, tp->snd_una),
("%s: SEQ_LEQ(th_ack, snd_una)", __func__)); | |
| 2832–2833 | Can remove this extra KASSERT() now, as we have removed the resume_partialack label. | |