Differential D53417

d.7: Document strchr, strjoin, strrchr, strstr, strtok, strlen, and substr
ClosedPublic
Actions

Authored by 0mp on Oct 28 2025, 8:20 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Group Reviewers

DTrace
manpages

Commits

rGd086bf34b56f: d.7: Document strchr, strjoin, strrchr, strstr, strtok, strlen, and substr
rGaf99c4c1d03c: d.7: Document strchr, strjoin, strrchr, strstr, strtok, strlen, and substr

Summary

MFC after: 2 weeks

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 68306
Build 65189: arc lint + arc unit

Event Timeline

0mp created this revision.Oct 28 2025, 8:20 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptOct 28 2025, 8:20 PM

0mp requested review of this revision.Oct 28 2025, 8:20 PM

Harbormaster completed remote builds in B68191: Diff 165253.Oct 28 2025, 8:20 PM

0mp added reviewers: DTrace, manpages.Oct 28 2025, 8:20 PM

markj subscribed.Oct 29 2025, 1:24 PM

markj added inline comments.

share/man/man7/d.7
208	What is returned if there is no match? NULL, or the empty string?
217	I don't think the comparison to strcat is useful. (Really, the comparisons to C functions in general isn't useful IMO: if you know C, then these functions are familiar, and if you don't the comparisons mean nothing.)

Add examples
Do not refer to C functions
Explain return values

Harbormaster completed remote builds in B68306: Diff 165571.Oct 31 2025, 2:00 PM

0mp marked 2 inline comments as done.Oct 31 2025, 2:01 PM

0mp added inline comments.

share/man/man7/d.7
208	I've added those details.
217	Good point. Thanks! I removed those pointers.

0mp marked 2 inline comments as done.Oct 31 2025, 2:01 PM

markj accepted this revision as: markj.Nov 2 2025, 5:09 PM

This revision is now accepted and ready to land.Nov 2 2025, 5:09 PM

Awesome! Thanks, Mark!

Closed by commit rGaf99c4c1d03c: d.7: Document strchr, strjoin, strrchr, strstr, strtok, strlen, and substr. · Explain WhyNov 2 2025, 7:22 PM

This revision was automatically updated to reflect the committed changes.

0mp added a commit: rGaf99c4c1d03c: d.7: Document strchr, strjoin, strrchr, strstr, strtok, strlen, and substr.

0mp added a commit: rGd086bf34b56f: d.7: Document strchr, strjoin, strrchr, strstr, strtok, strlen, and substr.Nov 18 2025, 1:38 PM

Revision Contents
Changeset List

Path

Size

share/

man/

man7/

124 line(s)

Diff 165571

share/man/man7/d.7

Loading...