Mark the pipe(2) system call as COMPAT10.
ClosedPublic
Actions

Authored by brooks on Jun 11 2016, 8:57 PM.

Details

Reviewers

peter
andrew

Commits

rS302095: Generate syscall tables and update pipe() implementation after r302094.
rS302094: Mark the pipe() system call as COMPAT10.

Summary

Libc now implements pipe() as a call to pipe2() which is identical when
called with a flags value of 0.

This depends on https://reviews.freebsd.org/D6815

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks updated this revision to Diff 17525.Jun 11 2016, 8:57 PM

brooks retitled this revision from to Mark the pipe(2) system call as COMPAT10..

brooks updated this object.

brooks edited the test plan for this revision. (Show Details)

brooks added reviewers: peter, andrew.

Herald added a subscriber: imp. · View Herald TranscriptJun 11 2016, 8:57 PM

In principle I think this is OK. As an aside, pipe2(2) should also be able to return EFAULT, but that isn't mentioned in the man page.

brooks mentioned this in D6815: Replace libc's call to pipe(2) with pipe2(2)..Jun 14 2016, 11:18 PM

Closed by commit rS302094: Mark the pipe() system call as COMPAT10. (authored by brooks). · Explain WhyJun 22 2016, 9:16 PM

This revision was automatically updated to reflect the committed changes.

juan.molina_club.fr added a subscriber: juan.molina_club.fr.Jun 22 2016, 10:36 PM

juan.molina_club.fr added inline comments.

head/sys/kern/syscalls.master
31	There is a small typo here, isn’t it? s/COMPAT7/COMPAT10

Revision Contents
Changeset List

Path

Size

head/

sys/

compat/

freebsd32/

syscalls.master

3 lines

kern/

syscalls.master

3 lines

Diff 17777

View Options

head/sys/compat/freebsd32/syscalls.master