Page MenuHomeFreeBSD
Differential D6852

Take maintainership editors/neovim
AbandonedPublic
Actions

Authored by gor_clogic.com.ua on Jun 15 2016, 9:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 2:16 AM
Unknown Object (File)
Nov 13 2023, 12:37 PM
Unknown Object (File)
Oct 25 2023, 8:51 AM
Unknown Object (File)
Oct 19 2023, 9:23 PM
Unknown Object (File)
Oct 11 2023, 1:23 PM
Unknown Object (File)
Oct 11 2023, 1:23 PM
Unknown Object (File)
Sep 13 2023, 3:37 PM
Unknown Object (File)
Aug 27 2023, 12:10 AM
View All 30 Files
Subscribers
mat
Contributor Reviewers (ports)

Details

Reviewers
None
Summary

Take maintainership editors/neovim and fix out-of-order DISTVERSIONPREFIX.

Test Plan

portlint && port test

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 4234
Build 4278: arc lint + arc unit

Event Timeline

gor_clogic.com.ua updated this revision to Diff 17595.Jun 15 2016, 9:48 AM
gor_clogic.com.ua retitled this revision from to Take maintainership editors/neovim.
gor_clogic.com.ua updated this object.
gor_clogic.com.ua edited the test plan for this revision. (Show Details)
Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptJun 15 2016, 9:48 AM
gor_clogic.com.ua added a reviewer: mat.Jun 15 2016, 9:48 AM
mat resigned from this revision.Jun 15 2016, 10:18 AM
mat removed a reviewer: mat.

Can you please stop adding people who didn't ask as reviewers ?

gor_clogic.com.ua added a comment.EditedJun 15 2016, 10:51 AM
In D6852#143796, @mat wrote:

Can you please stop adding people who didn't ask as reviewers ?

Yes of course, but I don't known who must be in reviewers.

mat added a comment.Jun 15 2016, 11:03 AM
In D6852#143799, @gor_clogic.com.ua wrote:
In D6852#143796, @mat wrote:

Can you please stop adding people who didn't ask as reviewers ?

Yes of course, but I don't known who must be in reviewers.

Well, when you are a committer, your mentors.

And in general, the people who are going to check this change before approving it, like the maintainer for a port, portmgr for a framework change...

This is a code review tool, not a bug submission tool. This here, looks like it belongs in a PR on https://bugs.freebsd.org/submit/

gor_clogic.com.ua added a comment.Jun 15 2016, 11:14 AM
In D6852#143800, @mat wrote:
In D6852#143799, @gor_clogic.com.ua wrote:
In D6852#143796, @mat wrote:

Can you please stop adding people who didn't ask as reviewers ?

Yes of course, but I don't known who must be in reviewers.

Well, when you are a committer, your mentors.

And in general, the people who are going to check this change before approving it, like the maintainer for a port, portmgr for a framework change...

This is a code review tool, not a bug submission tool. This here, looks like it belongs in a PR on https://bugs.freebsd.org/submit/

Thanks for clarifying. I will create PR on https://bugs.freebsd.org/

gor_clogic.com.ua added a comment.Jun 15 2016, 11:26 AM

Filed Issue for this https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210301

gor_clogic.com.ua abandoned this revision.Jun 19 2016, 3:19 PM

Committed.

Revision Contents
Changeset List

PathSize
editors/
neovim/
4 lines

Diff 17595

View Options

editors/neovim/Makefile

Loading...