D11270.1785645415.diff
No OneTemporary
Actions

Size

877 B

Referenced Files

None

Subscribers

None

D11270.1785645415.diff
View Options

	Index: head/sys/sys/refcount.h
	===================================================================
	--- head/sys/sys/refcount.h
	+++ head/sys/sys/refcount.h
	@@ -50,7 +50,7 @@
	{

	KASSERT(*count < UINT_MAX, ("refcount %p overflowed", count));
	- atomic_add_acq_int(count, 1);
	+ atomic_add_int(count, 1);
	}

	static __inline int
	@@ -58,10 +58,20 @@
	{
	u_int old;

	- /* XXX: Should this have a rel membar? */
	+ atomic_thread_fence_rel();
	old = atomic_fetchadd_int(count, -1);
	KASSERT(old > 0, ("negative refcount %p", count));
	- return (old == 1);
	+ if (old > 1)
	+ return (0);
	+
	+ /*
	+ * Last reference. Signal the user to call the destructor.
	+ *
	+ * Ensure that the destructor sees all updates. The fence_rel
	+ * at the start of the function synchronized with this fence.
	+ */
	+ atomic_thread_fence_acq();
	+ return (1);
	}

	#endif /* ! __SYS_REFCOUNT_H__ */