One of my old laptops lying around is an Asus G73Jh with a backlit keyboard.
Unfortunately, the keyboard backlight gets turned off when FreeBSD boots.
Fix this by adding a sysctl to control the keyboard backlight. I haven't figured out
how to get the Fn keys to work yet, but this works for now. It should work for a lot
of other Asus laptop models that don't use WMI, too.
Details
Details
- Reviewers
- None
- Group Reviewers
manpages
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Minor textual suggestion for the man page (outside of your change).
| share/man/man4/acpi_asus.4 | ||
|---|---|---|
| 52 | s/leds/LEDs/ (while we're here...) | |
Comment Actions
I don't remember this driver internals. My Asus laptops were using WMI interface, and even that I've written 8 years ago.
| sys/dev/acpi_support/acpi_asus.c | ||
|---|---|---|
| 166 | Identification with empty string sounds weird, unless they decided to standardize the interface once and forever, that I doubt, | |
| share/man/man4/acpi_asus.4 | ||
|---|---|---|
| 133 | Note the range of valid values. 0%-100%? 0-254? Something else? | |
Comment Actions
- Fix detection of the number of brightness levels supported by firmware and expose it as a read-only sysctl.
- Improve documentation of the allowed range of values.
- leds -> LEDs
| share/man/man4/acpi_asus.4 | ||
|---|---|---|
| 134 | "brightness". Please remember to run mandoc -Tlint and igor. | |
| share/man/man4/acpi_asus.4 | ||
|---|---|---|
| 127 | ||
Comment Actions
I don't know enough about ACPI to really comment on the code change. The manpage change looks fine, but please remember to bump .Dd when you actually commit.