xen/arm64: add aarch64 hypercall interface
Needs ReviewPublic
Actions

Authored by ehem_freebsd_m5p.com on Jul 2 2021, 5:38 AM.

Details

Reviewers

royger
mhorne
manu
andrew

Summary

These are the low-level interface for Xen on ARM64. Not all of the
interface is included since we don't use all portions of Xen's API.

This was broken off of a "xen/arm64: add xen platform" commit. The
original commit was on the large side, and the hypercall code seemed
distinct from other portions.

A few small adjustments were needed from the original implementation in

Submitted by: Elliott Mitchell <ehem+freebsd@m5p.com>
Original implementation: Julien Grall <julien@xen.org>, 2014-01-13 17:40:58

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 42509
Build 39397: arc lint + arc unit

Event Timeline

ehem_freebsd_m5p.com created this revision.Jul 2 2021, 5:38 AM

Herald added a reviewer: manu. · View Herald TranscriptJul 2 2021, 5:38 AM

Herald added a reviewer: Core Team. · View Herald Transcript

Herald added subscribers: emaste, andrew, imp. · View Herald Transcript

ehem_freebsd_m5p.com requested review of this revision.Jul 2 2021, 5:38 AM

Harbormaster completed remote builds in B40228: Diff 91648.Jul 2 2021, 5:38 AM

I had been expecting to manually flag this, but I see it has been setup to preemptively alert people.

That license does need checking. My reading is this falls under "when distributed separately from the Linux kernel or incorporated into other software packages, subject to the following license:"

This matches the license for sys/{amd64|i386}/include/xen/hypercall.h, so I believe this is acceptable.

ehem_freebsd_m5p.com added a child revision: D30950: xen/arm64: enable arm64 Xen configuration.Jul 2 2021, 5:50 AM

Any news from the core team? I can well imagine license reviews taking a while, but since this matches existing files I would expect that to greatly simplify things.

ehem_freebsd_m5p.com added a reviewer: emaste.Nov 2 2021, 3:47 AM

The Phabricator interface seems to suggest it is possible to remove the Core Team blocking review, but I suspect that is a no-no in cases like this. Due to this could @emaste or @imp give the Core Team okay? Appears the license was approved elsewhere and this isn't GPL (it is a permissive if separated from the Linux kernel).

I suspect @mhorne will be the final reviewer since this is for ARM64.

Was there a GPL reference in here before, or what did Herald flag on? Let's see...

kevans added inline comments.Nov 2 2021, 5:32 AM

sys/arm64/xen/hypercall.S
15	This looks like MIT; we probably want an SPDX tag at the top of this file? I reckon: `SPDX-License-Identifier: MIT`OR GPL-2.0

Adding suggested SPDX tag.

Harbormaster completed remote builds in B42509: Diff 97843.Nov 2 2021, 5:42 AM

ehem_freebsd_m5p.com removed reviewers: emaste, imp.Nov 2 2021, 5:49 AM

ehem_freebsd_m5p.com mentioned this in D32796: xen: add SPDX license tags to Xen headers.Nov 2 2021, 5:58 AM

imp added inline comments.Nov 2 2021, 2:20 PM

sys/arm64/xen/hypercall.S
2	`GPL-2.0` is deprecated and should not be used SPDX-License-Identifier: MIT OR GPL-2.0-only is the correct way to flag this.

Update to match comment.

Harbormaster completed remote builds in B42536: Diff 97897.Nov 2 2021, 11:16 PM

ehem_freebsd_m5p.com marked 2 inline comments as done.Nov 17 2021, 2:22 AM

Huh, I was so focused on interactions with @royger I missed that I've done rather substantial changes to what was D30996.

After a bunch of experimentation I finally figured got GCC's inline BSDM^Wassembly working. With this it becomes possible to mostly reuse the x86 "hypercall.h" on other architectures, which seems a rather superior approach.

I'm including the adjustments to the other headers to make the ARM64 header work. Those may get reviewed via e-mail by @royger, but someone else is certainly going to need to approve the ARM64 hypercall.h header.

Herald added a reviewer: andrew. · View Herald TranscriptJun 28 2023, 9:58 PM

Herald added a reviewer: andrew. · View Herald Transcript

Harbormaster completed remote builds in B52322: Diff 123933.Jun 28 2023, 9:58 PM