This is the first step for VRSS: multiple channel support. It passes build & simple test, and need more test.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jun 24 2016
May 11 2016
Mar 13 2016
Mar 1 2016
Feb 26 2016
Feb 25 2016
Yes, substract the next_gpadl_handle is risk here.
The update includes:
- Reuse "dev.DEV.UNIT." as sysctl root node instead of defining a new node.
- Separate the statisitc into two parts: hv_vmbus_channel_stat and hv_ring_buffer_stat. The former is owned by channel module, and the later is for ring_buffer module. Because the statistic needs to know which ring buffer it is: inbound or outbound, that is only known in channel level. It is not suitable to bind all logic to hv_vmbus_ring_buffer_init function even though I tried it but found the logic is not clean.
- Add the support for sub channel. There is a node "sub" in the output.
Feb 24 2016
My intension of creating more nodes is for printing clear message. We have to distinguish ring buffers on different channels, so they belong to the same node. Maybe we also needs to distinguish subchannels. Now I have not done this.
Feb 23 2016
hmm, it makes sense to put ring_buffer_stats function into hv_ring_buffer.c since only one function exists in that file.
Feb 17 2016
There is another succinct implementation with taskqueue_fast. Please reference https://reviews.freebsd.org/D5215
Feb 16 2016
Since there are some new added files, shall we modify the copyright to "2016"? I remember Sephie said there are some regulations on copyright.
LGTM
Feb 5 2016
Feb 4 2016
Looks ok to me.
Jan 31 2016
Jan 29 2016
Jan 28 2016
LGTM
Jan 27 2016
- hyperv: vmbus: refactor msg handler by replacing swi with task queue
Jan 21 2016
Jan 20 2016
It looks ok to me.
Jan 19 2016
Jan 18 2016
Jan 14 2016
Jan 12 2016
replace "false" with "FALSE" in order to be consistent with other "FALSE" in the same file.
According to howard0su_gmail.com's suggestion, I did corresponding modifications except for "boolean_t==>bool" in order to keep consistent in current file. In the future, I will do a special code refactor in order to align with FreeBSD's mainstream style.
Jan 11 2016
Looks ok to me.
Jan 8 2016
- When the statistic data was reset or cleared? I found if I enable LRO and run some test, and then disable LRO, the statistic data are still there.
- Please follow the style (9) for all "return" statement. e.g. "return IPPROTO_DONE;" should be changed to "return (IPPROTO_DONE);"
- For TUNABLE_INT("dev.hn.trust_hosttcp", &hn_trust_hosttcp); "dev.hn.trust_hosttcp" is not a generic option for network, instead it only makes sense for hyperv network driver, so could you please rename it to be "dev.hyperv.trust_hosttcp"? "hn" makes people think it is "hn0".
Jan 7 2016
Jan 6 2016
Nov 16 2015
refine the patch according to Wei Hu's comments
Nov 12 2015
Could you please help me review the bug fix?