Noted with thanks:
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Jul 6 2023
With reference to D40827:
Approved as is.
Jul 5 2023
Jul 4 2023
I don't have any IPv6-enabled network, but the test plan above looks simple enough for me to test with eduroam and one or two other environments.
Jul 1 2023
In D33959#790262, @grahamperrin wrote:https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262872
x11/gnome is not GNOME 3
Jun 29 2023
Jun 28 2023
Confirming the move of /boot/overlays to /boot/dtb/overlays, from 2018:
Jun 27 2023
… present on the ISO …
OK, I see /usr/freebsd-dist as the default BSDINSTALL_DISTDIR under https://man.freebsd.org/cgi/man.cgi?query=bsdinstall&sektion=8&manpath=freebsd-release#ENVIRONMENT_VARIABLES.
This is certainly clearer. Thanks.
Jun 26 2023
Jun 25 2023
(Some of these are comments because Phabricator seems to prevent suggestions for this review.)
Jun 23 2023
The 2023-06-13 patch from Tom Hukins.
Jun 22 2023
Jun 18 2023
Side notes:
Jun 12 2023
Thanks … at a glance, one of the reportedly done things is only partially done …
Jun 11 2023
In D40045#920224, @markj wrote:
Jun 10 2023
Jun 5 2023
Jun 4 2023
Jun 3 2023
Please: is this a candidate for inclusion in 14.0-CURRENT?
… Need last test: build with llvm15 from base and run on 14-CURRENT and 13-STABLE amd64 …
Big thanks for bringing this over from the wiki.
Jun 2 2023
In D39877#907821, @rmacklem wrote:
Jun 1 2023
I don't know the technology for this change, but the wording is good now.
May 30 2023
In D40254#917734, @grahamperrin wrote:https://www.freshports.org/emulators/virtualbox-ose/#history is currently at 6.1.44_1.
https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-naming-revepoch – if I understand correctly, D40254 should bump the PORTREVISION from 1 to 2 at line 3.
May 29 2023
May 28 2023
https://www.freshports.org/emulators/virtualbox-ose/#history is currently at 6.1.44_1.
May 27 2023
May 25 2023
In D40254#916487, @arrowd wrote:What's the rationale for patches? …
May 16 2023
Maybe peculiar that --ff-only is nowhere in the Updating and Upgrading FreeBSD chapter of the FreeBSD Handbook, however I'll commit as is.
May 15 2023
Where horizontal tabs are used, is this essential? Use of simple spaces, in lieu of tabs, will allow neatness (no raggedness).
May 13 2023
May 12 2023
May 10 2023
The two done comments.
May 9 2023
May 8 2023
Maybe refer to https://bugs.freebsd.org/261349 when committing. Thanks.
Maybe refer to https://bugs.freebsd.org/261349 when committing. Thanks.
Maybe refer to https://bugs.freebsd.org/261349 when committing. Thanks.
I don't yet have a build of the OS that includes efiwake, but the parts of the (non-rendered) manual page that I can read look OK to me. Thanks.
May 5 2023
I deleted this word in the previous set of suggestions. Maybe Phabricator did not recognise the deletion.
May 4 2023
Editing /usr/src/.git/COMMIT_EDITMSG, if I un-comment the Author line will that be enough for proper attribution?
May 3 2023
May 1 2023
Apr 27 2023
Apr 25 2023
Apr 24 2023
Apr 23 2023
Is this still accepted as it was in 2019?
Was this review overcome by events?
@carlavilla FYI
Apr 22 2023
In D22088#483028, @ota_j.email.ne.jp wrote:… Then, I'd like to update man swapon to discourage and mention zfs/zvol short coming.
For what it's worth, I would find a rule such as this useful without the rule being comprehensive, or perfect …
… no reviewers specified.
I would like to see it enabled.