Page MenuHomeFreeBSD
Feed Search

Oct 6 2023

bcr committed rGa5bebe4359ef: geom.4: Document kern.geom.notaste sysctl (authored by felix.the.red_gmail.com).
Oct 6 2023, 4:06 PM
bcr accepted D42107: mitigations.7: explain RELRO.

OK from manpages.

Oct 6 2023, 3:42 PM
bcr requested review of D42109: Bug 254897 - Document kern.geom.notaste sysctl.
Oct 6 2023, 3:21 PM
bcr added inline comments to D42107: mitigations.7: explain RELRO.
Oct 6 2023, 3:03 PM
bcr closed D40595: Bug 268052: Extend -p option of ps(1) with some clarifications.
Oct 6 2023, 2:32 PM
bcr committed rGd6ae056e9dc9: Extend description of -p to include interactions with -d and implying -x.
Oct 6 2023, 2:32 PM
bcr requested review of D42106: Bug 235946 - column(1): Fill order (with/without -x) is incorrectly documented.
Oct 6 2023, 1:56 PM
bcr requested review of D42102: Fix for bug 204530 - man 3 gmtime - struct tm documentation possibly incorrect.
Oct 6 2023, 10:10 AM
bcr committed rG07b2c79cc6c7: Correct the example: use maxproc instead of nonexistent nproc.
Oct 6 2023, 9:05 AM
bcr closed D40885: Fix for Bug 272357 - rctl.conf(5) resourcing name error.
Oct 6 2023, 9:05 AM

Oct 5 2023

bcr closed D42037: news: add 14.0-BETA4 entry.
Oct 5 2023, 3:00 PM
bcr committed R9:985db63a0b71: Add news entries for various BETA versions of FreeBSD 14..
Oct 5 2023, 3:00 PM
bcr committed R9:4b80089646c1: Remove whitespace at end of line, no content change.
Oct 5 2023, 2:51 PM
bcr closed D42013: porters handbook: make example follow suggestions in text.
Oct 5 2023, 2:49 PM
bcr committed R9:2b229d71ecd6: Porters handbook advises against patching configure, adjust example to match.
Oct 5 2023, 2:49 PM
Herald added a reviewer for D39824: arm64: add a driver for the Apple watchdog: andrew.

Is this review finished and can be closed?

Oct 5 2023, 10:38 AM
bcr added a comment to D40372: genl: add the monitor subcommand.

A fix for the man page.

Oct 5 2023, 10:23 AM
bcr added a comment to D40370: Infrastructure for automatic jailing of rc.d-services.

Two fixes for the man page.

Oct 5 2023, 10:20 AM · rc, Jails
bcr accepted D40529: certctl.8: document LOCALBASE.

OK from manpages.

Oct 5 2023, 10:14 AM
bcr added a comment to D41794: Add mitigations(7) describing our vulnerability mitigations.

Found a few typos.

Oct 5 2023, 9:25 AM
bcr accepted D41495: fortune: use 115200 in serial example.

Good to go

Oct 5 2023, 8:36 AM

Oct 4 2023

bcr added a comment to D42012: Status/2023Q3/gcc.adoc: Add report.

Two minor fixes.

Oct 4 2023, 2:38 PM
bcr accepted D42022: freebsd-update: add a note about when files may be deleted.

OK from the docs side of things.

Oct 4 2023, 2:24 PM
bcr added a comment to D42009: Handbook WG - Mail WIP.

Just adding a suggestion, the rest of the text looks fine to me.
Thanks for doing the work!

Oct 4 2023, 12:47 PM

Sep 28 2023

bcr committed R9:d6bc62b1243d: Add FOSDEM and AsiaBSDcon 2024 as events with dates for this year.
Sep 28 2023, 9:04 AM

Sep 19 2023

bcr added inline comments to D39761: freebsd-update: Print download progress in more terse way..
Sep 19 2023, 7:01 AM

Sep 17 2023

bcr added a comment to D39761: freebsd-update: Print download progress in more terse way..

Spotted something unrelated to his patch, just wanted to mention it.

Sep 17 2023, 5:29 PM

Sep 15 2023

bcr added inline comments to D41775: FDP: Add subsection about images and icons.
Sep 15 2023, 9:43 AM

Jul 18 2023

bcr added a comment to D40157: add defaults for adduser.sh (OK? [yes] & additional user [no]).

Can someone commit this, please? Would be good to have.

Jul 18 2023, 6:46 AM

Jul 6 2023

bcr updated the summary of D40885: Fix for Bug 272357 - rctl.conf(5) resourcing name error.
Jul 6 2023, 4:09 PM
bcr requested review of D40885: Fix for Bug 272357 - rctl.conf(5) resourcing name error.
Jul 6 2023, 4:09 PM
bcr accepted D40546: Handbook WG - network.

Looks good to me, thanks for working on this!

Jul 6 2023, 7:30 AM

Jun 30 2023

bcr accepted D40643: realgroupmember(9): Link to groupmember(9), document the function.

Looks good now, thank you.

Jun 30 2023, 7:29 AM

Jun 29 2023

bcr added inline comments to D40801: Reduce "grep foo | awk" chain of pipes to "awk /foo/".
Jun 29 2023, 5:31 PM
bcr updated the summary of D40801: Reduce "grep foo | awk" chain of pipes to "awk /foo/".
Jun 29 2023, 4:49 PM
bcr requested review of D40801: Reduce "grep foo | awk" chain of pipes to "awk /foo/".
Jun 29 2023, 4:45 PM
bcr added inline comments to D40643: realgroupmember(9): Link to groupmember(9), document the function.
Jun 29 2023, 4:13 PM
bcr accepted D40800: libstdbuf: Add proper SEE ALSO section..

Looks good to me.

Jun 29 2023, 4:12 PM
bcr added a comment to D40632: cr_bsd_visible(9): New man page.

Thanks for writing the man page. Run
mandoc -Tlint
and
textproc/igor
on it to see any extra warnings and get help fixing them.

Jun 29 2023, 4:12 PM
bcr added a comment to D40635: cr_canseeotheruids(9): Revamp, mark as internal.

Thanks for these man page updates.
Have you checked them with "mandoc -Tlint" and textproc/igor for any extra warnings these tools might emit?

Jun 29 2023, 4:09 PM
bcr added inline comments to D40636: cr_cansee(9): cr_bsd_visible() impacts, simplifications.
Jun 29 2023, 4:08 PM
bcr added a comment to D40637: p_cansee(9): Bring up-to-date, misc fixes.

Suggestion to simplify sentence at bit.

Jun 29 2023, 4:07 PM
bcr added inline comments to D40638: p_candebug(9): cr_bsd_visible() impacts, misc fixes.
Jun 29 2023, 4:05 PM
bcr added a comment to D40639: prison_check(9): Bring up-to-date with hierarchical jails.

Propose to use active voice in a sentence. The rest looks good.

Jun 29 2023, 4:03 PM
bcr updated the summary of D40798: Minor adjustments to embed_dtb.sh and make_dtbh.sh.
Jun 29 2023, 1:22 PM
bcr requested review of D40798: Minor adjustments to embed_dtb.sh and make_dtbh.sh.
Jun 29 2023, 1:21 PM
bcr accepted D40796: Improve man pages.

Not much to do for manpage syntax here, so approved.

Jun 29 2023, 12:47 PM
bcr updated the summary of D40797: beinstall.sh: Various shell scripting improvements.
Jun 29 2023, 12:42 PM
bcr updated the summary of D40797: beinstall.sh: Various shell scripting improvements.
Jun 29 2023, 12:42 PM
bcr requested review of D40797: beinstall.sh: Various shell scripting improvements.
Jun 29 2023, 12:40 PM

Jun 28 2023

bcr updated the diff for D40747: Add quotes around variables in adduser.sh and replace backticks with $().

Address comments:

  • turn $vars into ${var}
  • quote them and the $()
Jun 28 2023, 6:19 PM
bcr committed rG7776cec946fb: Add quotes around variables and replace backticks with $().
Jun 28 2023, 4:53 PM
bcr closed D40726: Add quotes to zzz.sh and replace legacy backticks with $().
Jun 28 2023, 4:53 PM

Jun 27 2023

bcr updated the diff for D40726: Add quotes to zzz.sh and replace legacy backticks with $().

Thanks for the feedback. I removed the extra whitespace at the line you mentioned and in another instance further down.

Jun 27 2023, 7:03 AM

Jun 24 2023

bcr added a comment to D40747: Add quotes around variables in adduser.sh and replace backticks with $().

Most of the $()'s should be quoted too, since you are already there, maybe get the script through shellcheck?

Jun 24 2023, 9:32 AM
bcr requested review of D40747: Add quotes around variables in adduser.sh and replace backticks with $().
Jun 24 2023, 8:32 AM
bcr requested review of D40745: Add double quotes to rmuser.sh and replace backticks with $().
Jun 24 2023, 7:08 AM

Jun 23 2023

bcr requested review of D40726: Add quotes to zzz.sh and replace legacy backticks with $().
Jun 23 2023, 4:55 PM
bcr committed rG764464af4968: Fix spelling of "behavior" to be consistent with the rest of the file.
Jun 23 2023, 5:49 AM

Jun 22 2023

bcr added inline comments to D40701: m4: Miscellaneous man page fixes..
Jun 22 2023, 6:20 PM

Jun 21 2023

bcr added a comment to D40595: Bug 268052: Extend -p option of ps(1) with some clarifications.

Thanks for the grammar hint. Fixed.

Jun 21 2023, 4:37 PM
bcr updated the diff for D40595: Bug 268052: Extend -p option of ps(1) with some clarifications.

Fix spelling of descendant.

Jun 21 2023, 4:37 PM
bcr accepted D40694: m4: Support long options..

OK for the manpages part. Thanks.

Jun 21 2023, 4:34 PM

Jun 20 2023

bcr accepted D40675: Remove devices removed from the 13.0 release from hardware notes.

Approved, thanks!

Jun 20 2023, 6:53 PM
bcr updated the diff for D40606: Fix some shell issues in etcupdate.sh.

Updated diff addressing @bsdimp's comments. I changed the "$var"/"something" to "$var/something" to make it easier to read. When required, I can also wrap those variables to be ${var} if necessary.

Jun 20 2023, 5:13 PM

Jun 19 2023

bcr added a comment to D40606: Fix some shell issues in etcupdate.sh.

Alright, I can provide a diff that does that. Makes it easier to read. I'll update this revision when it's ready.

Jun 19 2023, 3:15 PM
bcr requested review of D40606: Fix some shell issues in etcupdate.sh.
Jun 19 2023, 2:06 PM
bcr committed rG7ad4d94d5bf2: Fix some shell issues by adding quotes and replace backticks with $().
Jun 19 2023, 11:08 AM
bcr closed D40604: Fix some shell issues by adding quotes in fwget.sh.
Jun 19 2023, 11:07 AM
bcr requested review of D40604: Fix some shell issues by adding quotes in fwget.sh.
Jun 19 2023, 9:48 AM
bcr accepted D40313: fdp-primer: Add Weblate chapter.
Jun 19 2023, 5:51 AM
bcr added a comment to D40313: fdp-primer: Add Weblate chapter.

I've read through it and found noting wrong with it.
Great work. I think this will make it more visible to people when it is part of the Primer.

Jun 19 2023, 5:51 AM

Jun 18 2023

bcr updated the summary of D40595: Bug 268052: Extend -p option of ps(1) with some clarifications.
Jun 18 2023, 9:12 AM
bcr requested review of D40595: Bug 268052: Extend -p option of ps(1) with some clarifications.
Jun 18 2023, 9:10 AM
bcr added a comment to D37404: wg.8: Rewrite the manual page.

@gbe: Did you have time to work on this yet? Let me know if you need some help finishing this.

Jun 18 2023, 8:42 AM

May 29 2023

bcr added a comment to D40313: fdp-primer: Add Weblate chapter.

Amazing work, this will definitely be helpful to have in the Primer instead of the wiki. Thanks for your work.
I've added a few minor fixes and suggestions.

May 29 2023, 8:17 AM

May 28 2023

bcr accepted D40285: libtacplus: Allow additional AV pairs to be configured..
May 28 2023, 6:07 PM

May 23 2023

bcr added a comment to D34004: website: Rework the downloads table.

What is the status of this? Is anyone still working on it?
A lot of people comment on this table still needing improvements.

May 23 2023, 7:54 AM
bcr abandoned D19934: Add an "Event: " line to the commit messages to not abuse the "Sponsored by:" line.

Overcome by events, less critical these days.

May 23 2023, 7:53 AM
bcr accepted D40217: Update handbook/pkg-files#pkg-message to use sysrc and service .

Looks good, both the German and English versions. Much appreciated!

May 23 2023, 7:51 AM
bcr accepted D40214: FAQ: switch Subversion references to Git.

Looks good. I'm also OK with removing the sentence you mentioned.

May 23 2023, 5:49 AM

May 22 2023

bcr accepted D40203: hier.7: update /home.

OK from manpages. Bump the .Dd for this content change when you commit it.
Thank you!

May 22 2023, 3:35 PM

May 20 2023

bcr added a comment to D33168: gpart: add options to move the primary and secondary GPT partition tables.

Can we get an update on the status of this review?

May 20 2023, 2:13 PM
bcr resigned from D23398: Add USES=mono:build notes to PHB.

Resign from this change. We would have to re-implement it in AsciiDoctor anyway these days.

May 20 2023, 2:12 PM
bcr resigned from D25367: Add Nginx section to the Network Servers chapter in addition to Apache..

Overcome by events (DocBook XML migration, mentee timeout).

May 20 2023, 2:07 PM
bcr accepted D32132: kern/param: implement generalized enum sysctl reporting function.

OK from manpages. Please bump the .Dd when committing.

May 20 2023, 2:02 PM
bcr added a comment to D38490: ping: Accept ToS keywords with -z.

Any updates here? I'd be happy to approve the man page change.

May 20 2023, 2:01 PM
bcr resigned from D37354: Port HAMMER2 from DragonFly (read-only support).

There is now a port committed as sysutils/hammer2, based on work done in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267982 .
I think we can safely close this review.

May 20 2023, 1:57 PM
bcr added a comment to D31126: vget(9): update after r364271.

Any update on this?

May 20 2023, 1:52 PM
bcr removed a reviewer for D34748: riscv: add Allwinner D1 device tree: Core Team.

Remove core-team, as we do not seem to get involved in this.

May 20 2023, 1:50 PM
bcr removed a reviewer for D26552: Revert DTS for omap family for stable/12 and releng 12.2: Core Team.

Remove core-team, as we do not need to get involved.
Would still like to see someone commit this...

May 20 2023, 1:47 PM · ARM

May 19 2023

bcr updated subscribers of D40164: Show that 13.2 is the preferred release and 12.4/13.1 are legacy.

@carlavilla: Does that look correct to you?

May 19 2023, 5:29 PM
bcr accepted D40159: date: add -z output_zone option.

OK for the man page part.

May 19 2023, 1:20 PM

May 18 2023

bcr committed R9:b2f883f5a2d9: Remove instances of "in order to" to ease readability.
May 18 2023, 3:54 PM

May 17 2023

bcr accepted D40135: pam_tacplus: Mention nss_tacplus in the manual page..

OK from manpages.

May 17 2023, 3:52 PM
bcr added a comment to D32700: nvmecontrol: Implement Get/Set Feature for nvmecontrol.

Any update on this?

May 17 2023, 3:51 PM
bcr accepted D40133: Add nss_tacplus, a TACACS+ NSS module..

OK for the manpage part of the change.

May 17 2023, 1:09 PM
bcr accepted D40134: phb/testing: Pet vale.

Looks good, thanks for making the changes.

May 17 2023, 1:08 PM · portmgr

May 16 2023

bcr accepted D40003: ix(4): correct max MTU.

OK from docs (that's a separate group for doc reviews like this).

May 16 2023, 8:14 PM
bcr added a comment to D33233: sync.8: Document that the "sync dance" is not a thing.

@0mp: Can you commit this?

May 16 2023, 6:36 PM