OK from manpages.
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Oct 6 2023
Oct 5 2023
Is this review finished and can be closed?
A fix for the man page.
Two fixes for the man page.
Found a few typos.
Oct 4 2023
Two minor fixes.
OK from the docs side of things.
Just adding a suggestion, the rest of the text looks fine to me.
Thanks for doing the work!
Sep 28 2023
Sep 19 2023
Sep 17 2023
Spotted something unrelated to his patch, just wanted to mention it.
Sep 15 2023
Jul 18 2023
Can someone commit this, please? Would be good to have.
Jul 6 2023
Looks good to me, thanks for working on this!
Jun 30 2023
Looks good now, thank you.
Jun 29 2023
Thanks for writing the man page. Run
mandoc -Tlint
and
textproc/igor
on it to see any extra warnings and get help fixing them.
Thanks for these man page updates.
Have you checked them with "mandoc -Tlint" and textproc/igor for any extra warnings these tools might emit?
Suggestion to simplify sentence at bit.
Propose to use active voice in a sentence. The rest looks good.
Not much to do for manpage syntax here, so approved.
Jun 28 2023
Address comments:
- turn $vars into ${var}
- quote them and the $()
Jun 27 2023
Thanks for the feedback. I removed the extra whitespace at the line you mentioned and in another instance further down.
Jun 24 2023
In D40747#927028, @delphij wrote:Most of the $()'s should be quoted too, since you are already there, maybe get the script through shellcheck?
Jun 23 2023
Jun 22 2023
Jun 21 2023
Thanks for the grammar hint. Fixed.
Fix spelling of descendant.
OK for the manpages part. Thanks.
Jun 20 2023
Approved, thanks!
Updated diff addressing @bsdimp's comments. I changed the "$var"/"something" to "$var/something" to make it easier to read. When required, I can also wrap those variables to be ${var} if necessary.
Jun 19 2023
Alright, I can provide a diff that does that. Makes it easier to read. I'll update this revision when it's ready.
I've read through it and found noting wrong with it.
Great work. I think this will make it more visible to people when it is part of the Primer.
Jun 18 2023
@gbe: Did you have time to work on this yet? Let me know if you need some help finishing this.
May 29 2023
Amazing work, this will definitely be helpful to have in the Primer instead of the wiki. Thanks for your work.
I've added a few minor fixes and suggestions.
May 28 2023
May 23 2023
What is the status of this? Is anyone still working on it?
A lot of people comment on this table still needing improvements.
Overcome by events, less critical these days.
Looks good, both the German and English versions. Much appreciated!
Looks good. I'm also OK with removing the sentence you mentioned.
May 22 2023
OK from manpages. Bump the .Dd for this content change when you commit it.
Thank you!
May 20 2023
Can we get an update on the status of this review?
Resign from this change. We would have to re-implement it in AsciiDoctor anyway these days.
Overcome by events (DocBook XML migration, mentee timeout).
OK from manpages. Please bump the .Dd when committing.
Any updates here? I'd be happy to approve the man page change.
There is now a port committed as sysutils/hammer2, based on work done in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267982 .
I think we can safely close this review.
Any update on this?
Remove core-team, as we do not seem to get involved in this.
Remove core-team, as we do not need to get involved.
Would still like to see someone commit this...
May 19 2023
@carlavilla: Does that look correct to you?
May 18 2023
May 17 2023
OK from manpages.
Any update on this?
OK for the manpage part of the change.
Looks good, thanks for making the changes.
May 16 2023
OK from docs (that's a separate group for doc reviews like this).
@0mp: Can you commit this?