I have not checked each and every conversion but spotted a few vap and ic ones in between as well as the change in VHT. If it compiles, ship it.

migrate prefix to net80211_

rename prefix to net80211_

use net80211_ prefix

update commit message (locally)

In D50642#1156201, @bz wrote:

So i was thinking if we can start using ieee80211 for standards things and use a net80211 prefix for our own stuff (at least for anything new or we change)?

So i was thinking if we can start using ieee80211 for standards things and use a net80211 prefix for our own stuff (at least for anything new or we change)?

For once the if_printf changes are in

Please add:

In D50638#1156017, @bz wrote:

Need to check all the other places which may have changed implicit behaviour too and they all need the same comment,

update from bz; matches what's in CCMP

Need to check all the other places which may have changed implicit behaviour too and they all need the same comment,

comments from bz

comments from bz

just style; so do and push them; no need to upload again

Just style.

In D49419#1147670, @bz wrote:

Sorry I don't know; this window came up in a restored browser session; I thought I had submitted this ages ago.

comment from bz

comments from bz

Updated per comments

In D50264#1147001, @farhan_farhan.codes wrote:

I updated it as follows, which is in the spirit of what the script produces:

avp->av_dev = make_dev(&wtap_cdevsw, 0, UID_ROOT, GID_WHEEL, 0600,                                                "%s", (const char *)vap->iv_ifp->if_xname);

Regarding not including if_private.h directly, not including it results in missing structs. Also, other code imports it directly.

If there is another way, what exact patterns of includes are you suggesting?

fixed, i hope!

rebase

update from bz

update from bz

update from bz

Scrolling through apart from the local variable this looks good.

LGTM

If you remove the local variable then this is fine (it's also fine this way). I may not see this again before Thu so please go ahead.

So I'm going to do the "clean up if_private.h abuse in net80211" work in different diffs, and I plan on just leaving this diff as a straight refactor.

rebase

rebase

add some more stuff

implement a separate copy routine, get rid of the last reference.

Bump :)

Scrolling through again this looks good. Thanks a lot for all the follow-up changes (incl. the extra one folding the ic_printf arguments into one line :) ).

comment fixes; address a bug that bz caught, thanks!

address comments from bz@

Hi,
Checking if there are any updates necessary to merge this?

address comments from bz

Sorry I don't know; this window came up in a restored browser session; I thought I had submitted this ages ago.

Current Problem: Running into a recursive mutex based on FreeBSD/OpenBSD mutex styles.

In D50264#1146885, @jhibbits wrote:

I'm not sure why this was never connected to the build, I would have fixed it during my IfAPI work if it were connected then.

You can use the script tools/ifnet/convert_ifapi.sh to assist in converting the driver to IfAPI.

I'm not sure why this was never connected to the build, I would have fixed it during my IfAPI work if it were connected then.

Ordering of includes. It builds.

feedback from bz

guard the debug sysctl by MTW_DEBUG, which is defined if USB_DEBUG is defined, like if_run does it..

Changed Taiwan's from "Taiwan, Province of China" back to "Taiwan".

Working to update the athn_usb_init, currently working through the newstate handler.

In D50188#1144718, @lwhsu wrote:

FreeBSD uses a list derived from ISO 3166 [1], which is at src/share/misc/iso3166. It would be nice if we can have this enum generated from that list so we have a single source of truth.

FreeBSD uses a list derived from ISO 3166 [1], which is at src/share/misc/iso3166. It would be nice if we can have this enum generated from that list so we have a single source of truth.

in general +1, but why put debugging behind USB_DEBUG ? Doesn't USB_DEBUG pull in a bunch of other stuff?