D54218: Introduce libusb20_dev_open_with_flags for shared vs. exclusive access.
rebased

D54296: PR 291774: expand range of errors reported by libusb_open(3)
rebased to latest

D54231: libusb20_dev_open(3) and libusb20_be_device_foreach(3) man pages.
Fixed linter warnings.

Hey Rick! Thanks for the ping. Tip: use the linter,

mandoc -Tlint here/is/the/manual

D54218: Introduce libusb20_dev_open_with_flags for shared vs. exclusive access.
RETURN VALUES

D54218: Introduce libusb20_dev_open_with_flags for shared vs. exclusive access.
punctuation

D54231: libusb20_dev_open(3) and libusb20_be_device_foreach(3) man pages.
punctuation

D54231: libusb20_dev_open(3) and libusb20_be_device_foreach(3) man pages.
RETURN VALUES and fix unwanted line break in Bl/El list.

Superseded by D52861 and D52862

rebase

More typo fixes and drop __FBSDID tags

Roll typo fixes into this revision

thanks for your review!

Remove nhi_compat.h, typo

I give this a quick look over and left a couple of comments/questions. That said, I think it's reasonable to commit this to the tree and iterate on it there.

Accept all USB4 class PCI devices in nhi_pci_probe

Fixes

Fixes

Stuck on athn_usb_detach code or executes athn_usb_stop multiple times
I suspect this is due to the msleep on one threat and a wakeup on another, but I am not certain how to isolate the problem.

Current Problem: Running into a recursive mutex based on FreeBSD/OpenBSD mutex styles.

Working to update the athn_usb_init, currently working through the newstate handler.

Add missing router defines.

Don't touch router defines; this should be done in D49452.

In D49884#1137462, @imp wrote:

In D49884#1137457, @lwhsu wrote:

I think the current idea is avoiding directly import firmware file into repo. Perhaps we can separate the firmware out. The current approach is using firmware ports/pkg, before having that, we can just put it somewhere and ask people to grab it and put to the required place, for testing.

Or point them at the linux wireless firmware archive repo....

In D49884#1137457, @lwhsu wrote:

I think the current idea is avoiding directly import firmware file into repo. Perhaps we can separate the firmware out. The current approach is using firmware ports/pkg, before having that, we can just put it somewhere and ask people to grab it and put to the required place, for testing.

I think the current idea is avoiding directly import firmware file into repo. Perhaps we can separate the firmware out. The current approach is using firmware ports/pkg, before having that, we can just put it somewhere and ask people to grab it and put to the required place, for testing.

In D49450#1128475, @imp wrote:

This will take me a while to slog through.
Do you have pointers to online references to USB4 / TB standards you're emplementing?

This will take me a while to slog through.
Do you have pointers to online references to USB4 / TB standards you're emplementing?

I'll take a look once you're done with the planned changes you've flagged.

I want to factor out a notify function first.

yay!

Updated to compile and work with the new ifabi changes.

Thanks for the heads up! Looking into it...

hi! I just tried compiling this on -HEAD (to land it today!) and it failed; it looks like you need to go adapt it to the iflib/ifnet changes (ie, that hid struct ifnet behind if_private.h.)

Integrate suggestions from Zhenlei Huang (zlei@); thank you!

The manpage changes look great to me!

In D48167#1103394, @ziaee wrote:

I'm so excited to test this driver this weekend! Thank you so much for submitting this! All of the suggestions I made are to bring it into alignment with the rest of the freebsd manual and are specified in the manual page style guide, style.mdoc(5). Sorry I'm so late.

This change applies the rest of the changes suggested to the manual pages.

I'm so excited to test this driver this weekend! Thank you so much for submitting this! All of the suggestions I made are to bring it into alignment with the rest of the freebsd manual and are specified in the manual page style guide, style.mdoc(5). Sorry I'm so late.

This update to the diff brings:

Here's what I've got so far for the manual. I ordered some parts to test but they're not all here yet.

In D48167#1103157, @khorben_defora.org wrote:

I am currently looking into adding the SPDX license identifier, but it can also be done in a separate review.

Ok, i'll wait for the SPDX addition and then if I don't get any other feedback I'll land it

In D48167#1103156, @adrian wrote:

I think it's fine as-is to go in the tree, it's been two years and I'd like to see this in before -15.

I think it's fine as-is to go in the tree, it's been two years and I'd like to see this in before -15.

Address feedback from lwhsu@; thanks!