Delete content instead of removing the whole directory

In D54757#1251289, @jrtc27 wrote:

In D54757#1251288, @aokblast wrote:

In D54757#1251272, @jrtc27 wrote:

I don’t understand, other than it sounding like bear is broken

Sorry, the commit message is not clear. I try to explain with more detail. Please tell me if you need anymore information.

When

pwd == $OBJTOP

, and after

run rm -rf "$OBJTOP"

getcwd(3) will return with error since the directory is deleted.

Under this condition:

When shell is executing:

mkdir -p "$OBJTOP"

bear intercepts the libc exec(3) function call and call getcwd in here. As a result, it causes an error.

So... bear makes assumptions that are false and breaks perfectly fine build system code

In D54757#1251272, @jrtc27 wrote:

I don’t understand, other than it sounding like bear is broken

In D54551#1248714, @markj wrote:

Looks ok, but I'd use int in the function signature.

Minor fixes

Remove License message

Move commit back

Move commit back

Seperate differential

Minor fixes

Use x86_msr_op

Simplify dump_sysctl_cb
Add helper functions for single cpu

Thanks! Thought I sucessfully booted up on a AMD64 machine, this patch touches the basic logic of smp so I will think twice before landing it.

In D54466#1244696, @ziaee wrote:

Thanks aokblast!

This belongs in DESCRIPTION section.
The mdoc(7) manual specifies what goes in SYNOPSIS.

Also, each new sentence starts on a new line.

Minor fixes

Trust sc->req in set_epp and add () in KASSERT

Use hwpstate_amd instead of hwpstate
Not short-circuiting for cpu

In D54173#1238612, @unitrunker_unitrunker.net wrote:

Now I have a dilemma.

I can add exclusivity inside libusb20.c or push down one more layer and add this to the backend in libusb20_ugen20.c. To do this in the backend, device_open_t gets a third parameter for the flag. It's a six-for-one, half-dozen-for-the-other kind of decision.

The scope for this change is exclusivity. No plans to touch existing enumeration behavior.

I'll have to create a separate review. Everything will link back to the same bug.