Page MenuHomeFreeBSD
Feed Search

Thu, Jan 22

ziaee committed rG98cb4874e2bb: simd.7: Add Arm MOPS memcpy(), memmove() and memset() to manpage (authored by sarah.walker2_arm.com).
Thu, Jan 22, 9:08 PM
ziaee committed rG2c6bee2b23db: socket.2: Cross-reference protocol families (authored by tembun_bk.ru).
Thu, Jan 22, 9:08 PM

Tue, Jan 20

ziaee added a comment to D54801: dtrace: prefer less over more.

Why? When you call invoke less as "more" it works exactly the same but gives a classic BSD status line at the bottom.

Tue, Jan 20, 9:36 PM · docs
ziaee added inline comments to D54592: Add pdrfork(2) and pdwait(2).
Tue, Jan 20, 1:48 PM

Mon, Jan 19

ziaee accepted D54466: ichwd: Add manual for i6300esb watchdog.

Roff requires one sentence per line, so period always starts a new line. The linter will catch these basic issues, you can use it with mandoc -Tlint here/is/the/manual.

Mon, Jan 19, 8:11 PM
ziaee added a comment to D54519: mfi(4)/mrsas(4): Print driver versions consistently.

I agree with this from a doc principle but I don't know enough from a C standpoint, I'd like @emaste or @imp to check it.

Mon, Jan 19, 7:18 PM
ziaee added inline comments to D54784: 15.0/errata: increase loader regression verbosity.
Mon, Jan 19, 5:39 PM
ziaee updated the diff for D54784: 15.0/errata: increase loader regression verbosity.

remove set eficom

Mon, Jan 19, 5:39 PM
ziaee requested review of D54784: 15.0/errata: increase loader regression verbosity.
Mon, Jan 19, 5:31 PM
ziaee added a comment to D54231: libusb20_dev_open(3) and libusb20_be_device_foreach(3) man pages..

Hey Rick! Thanks for the ping. Tip: use the linter,

mandoc -Tlint here/is/the/manual
Mon, Jan 19, 5:25 PM · USB

Sat, Jan 17

ziaee added a comment to D54759: spi: use better logic for earlier change.

this uses saner code variant for change just done recently

Sat, Jan 17, 5:36 PM
ziaee added a reviewer for D54753: queue(3): add function-based API: brooks.
Sat, Jan 17, 3:45 PM · Contributor Reviews (src)
ziaee added inline comments to D54753: queue(3): add function-based API.
Sat, Jan 17, 3:45 PM · Contributor Reviews (src)
ziaee accepted D54434: socket.2: Cross-reference protocol familiy man pages in section 4.

I think this looks great! Let's wait for a second opinion on the content and then I'd be happy to take this.

Sat, Jan 17, 2:46 PM · manpages
ziaee added a comment to D54753: queue(3): add function-based API.

Unfortunately parsing diffs from git format-patch from phabricator side seems to be broken. It only shows the first (and the most trivial) commit. I'm using basic git diff here.

Sat, Jan 17, 5:32 AM · Contributor Reviews (src)
ziaee added a reviewer for D54753: queue(3): add function-based API: manpages.
Sat, Jan 17, 5:27 AM · Contributor Reviews (src)

Fri, Jan 16

ziaee accepted D53786: netlink(4): add snl(3) to See Also section.

Personally, I prefer a manual to stick strictly to its own contents and avoid referencing other libraries in the main text which keeps it concise and easier to read

Fri, Jan 16, 10:02 PM
ziaee committed rGfd34f549b711: termios.4: Cross-reference stack(9) for STATUS (authored by tembun_bk.ru).
Fri, Jan 16, 8:28 PM
ziaee closed D54701: termios.4: Cross-reference stack(9) for the STATUS character.
Fri, Jan 16, 8:27 PM · manpages
ziaee added a comment to D54701: termios.4: Cross-reference stack(9) for the STATUS character.

This is such a beautifully structured manual. People often abuse .Sh when really they should be subsections of DESCRIPTION. Thanks for the patch Artem!

Fri, Jan 16, 8:27 PM · manpages
ziaee accepted D54748: mac(4): also list jails in the example enumeration of objects.

Thanks for doing this!

Fri, Jan 16, 8:07 PM
ziaee added a reviewer for D54734: spi(8) - "-S" option for continuous stream from standard input to bus: manpages.
Fri, Jan 16, 1:04 AM
ziaee added inline comments to D54734: spi(8) - "-S" option for continuous stream from standard input to bus.
Fri, Jan 16, 1:04 AM

Thu, Jan 15

ziaee added inline comments to D54636: rtadvd: add multi pref64 support.
Thu, Jan 15, 5:48 PM
ziaee added a comment to D54688: src.conf.5: Cross-reference uname(1) man page.

I still do (nonblocking, if anyone else is free) but I'm swamped at $dayjob and idk when I'll be able to get to it.

Thu, Jan 15, 5:01 PM · manpages
ziaee accepted D54701: termios.4: Cross-reference stack(9) for the STATUS character.

Thanks for the ping! I get busy and forget about stuff so I really appreciate pings!

Thu, Jan 15, 4:42 PM · manpages
ziaee abandoned D54206: x11-fonts/dejavu: Remove stale pkg-message.

Sunpoet committed this from bugzilla

Thu, Jan 15, 1:54 PM

Wed, Jan 14

ziaee added inline comments to D54701: termios.4: Cross-reference stack(9) for the STATUS character.
Wed, Jan 14, 5:28 PM · manpages
ziaee added a comment to D54115: x86: Create manpage for mca subsystem.

I tried to test this, but the patch failed to apply

Wed, Jan 14, 5:26 PM
ziaee added a comment to D54688: src.conf.5: Cross-reference uname(1) man page.

Ah, I misunderstood then, sorry. Over lunch I'll test this.

Wed, Jan 14, 1:41 PM · manpages
ziaee requested review of D54707: prepare-commit-msg: Sync with committers guide.
Wed, Jan 14, 1:28 PM
ziaee closed D54448: committers-guide: Add Closes: commit msg trailer.
Wed, Jan 14, 1:07 PM
ziaee committed R9:e8e92b6a186e: committers-guide: Add Closes: commit msg trailer.
Wed, Jan 14, 1:06 PM
ziaee added a comment to D54688: src.conf.5: Cross-reference uname(1) man page.

I don't think this is the diff you intended to upload based on the commit message title. Also, please format patches with -U9999 so we can see the context

Wed, Jan 14, 12:59 PM · manpages
ziaee committed rG4cb65fde79a2: wc: Fix usage and manual SYNOPSIS + nits.
Wed, Jan 14, 12:54 AM
ziaee committed R9:92ff61601c6e: articles/pam: Increment number of control flags (authored by sn.khalatyan_gmail.com).
Wed, Jan 14, 12:50 AM
ziaee committed R9:5c9832dab53e: 15.0/eratta: 15.0 doesn't boot on apple G5.
Wed, Jan 14, 12:50 AM
ziaee committed R9:4faf0e7a8a20: 15.0/errata: Document loader hanging regression.
Wed, Jan 14, 12:50 AM
ziaee abandoned D54670: 15.0/eratta: 15.0 doesn't boot on apple G5.
Wed, Jan 14, 12:49 AM
ziaee added a comment to D54670: 15.0/eratta: 15.0 doesn't boot on apple G5.

Phabricator is disconnected somehow, but I updated this and just commit it

Wed, Jan 14, 12:49 AM
ziaee updated the diff for D54670: 15.0/eratta: 15.0 doesn't boot on apple G5.

corrected info, tagged bug. thanks @adrian!

Wed, Jan 14, 12:49 AM
ziaee requested review of D54670: 15.0/eratta: 15.0 doesn't boot on apple G5.
Wed, Jan 14, 12:49 AM

Mon, Jan 12

ziaee committed rG7ff1d2be5dc2: MAINTAINERS/CODEOWNERS: Fix intro wrap + gitadm.
Mon, Jan 12, 2:40 PM
ziaee committed rG2fb7c416c866: MAINTAINERS/CODEOWNERS: Add ziaee to mandoc + man/.
Mon, Jan 12, 2:40 PM
ziaee added a reviewer for D54660: jexec: Add -e parameter to customize the environment: manpages.
Mon, Jan 12, 12:20 PM · Jails
ziaee accepted D53910: website: complete refresh of beastie theme.

I think we have made a lot of progress on this, and the greatest points of controversy are resolved. To me, if this is acceptable to the major stake holders, I can merge this and we can continue iterating in the tree.

Mon, Jan 12, 10:23 AM

Fri, Jan 9

ziaee added a comment to D54630: mrsas(4): Drop 'FreeBSD' in version banner.

If the point is to align the two driver strings, I think that's one logical change and could/should be one commit.

Fri, Jan 9, 9:50 PM
ziaee added a comment to D54519: mfi(4)/mrsas(4): Print driver versions consistently.

I think if you want to make them the same you should remove FreeBSD from both. If people search logs for FreeBSD they shouldn't get these drivers, I think.

Fri, Jan 9, 9:19 PM
ziaee added a comment to D54519: mfi(4)/mrsas(4): Print driver versions consistently.

correctly capitalizing MegaRAID, and expanding version all sound good to me.

Fri, Jan 9, 7:28 PM
ziaee requested review of D54629: trimdomain.3: Explain DISPLAY a a bit more.
Fri, Jan 9, 6:44 PM
ziaee added inline comments to D54622: libutil: take a size_t in trimdomain().
Fri, Jan 9, 6:08 PM
ziaee added a comment to D54433: 15.0R/relnote: Improve upgrading with packages.
In D54433#1244080, @pi wrote:

Will it also explain pkgbasify ?

Fri, Jan 9, 4:24 PM
ziaee added a comment to D54433: 15.0R/relnote: Improve upgrading with packages.

I think my text still could use improvement, but to me almost all of these suggestions is going the wrong way towards "explain them to death".

Fri, Jan 9, 4:20 PM
ziaee added reviewers for D54448: committers-guide: Add Closes: commit msg trailer: vexeduxr, imp.
Fri, Jan 9, 4:18 PM
ziaee abandoned D54563: 15.0/errata: Mention possiblity of disabling ipfw.

Committed without review

Fri, Jan 9, 4:15 PM
ziaee committed R9:1aa40244a18d: 15.0/errata: Mention possiblity of disabling ipfw.
Fri, Jan 9, 4:12 PM
ziaee added inline comments to D52885: style.9: Encourage style changes when doing significant modifications.
Fri, Jan 9, 4:08 PM
ziaee added a comment to D54611: freebsd-base.7: Fix stray -r.

Don't forget to mfc

Fri, Jan 9, 12:13 PM
ziaee committed rGd1f93ea2e164: pkgbase.7: Show pkg upgrade to apply updates (authored by grahamperrin).
Fri, Jan 9, 5:37 AM

Thu, Jan 8

ziaee added inline comments to D53910: website: complete refresh of beastie theme.
Thu, Jan 8, 5:31 PM
ziaee committed rGd2f1c8e0d1be: Makefile: Update doxygen requirements (authored by minsoochoo0122_proton.me).
Thu, Jan 8, 2:02 PM

Wed, Jan 7

ziaee added a comment to D54133: bhyve: support MTU configuration for SLIRP net backend.

Please fix the commit message though, this is not a commit to bhyve.8 and it is not just adding things to the manual

Wed, Jan 7, 9:53 PM
ziaee closed D54515: sysutils/cpu-microcode-intel: Dont depend on cpu-microcode-rc.
Wed, Jan 7, 9:43 PM
ziaee committed R11:5b4090e27da9: sysutils/cpu-microcode-intel: Dont depend on cpu-microcode-rc.
Wed, Jan 7, 9:43 PM
ziaee updated the diff for D54515: sysutils/cpu-microcode-intel: Dont depend on cpu-microcode-rc.

remove Intel CPUs

Wed, Jan 7, 9:30 PM
ziaee added inline comments to D54515: sysutils/cpu-microcode-intel: Dont depend on cpu-microcode-rc.
Wed, Jan 7, 9:11 PM
ziaee updated the diff for D54515: sysutils/cpu-microcode-intel: Dont depend on cpu-microcode-rc.

added PORTREVISION, fixed OPTIONS_DEFAULT; thanks @jrm!

Wed, Jan 7, 9:11 PM
ziaee added inline comments to D44458: coredirector - Intel TD/HFI driver - Part6: Add coredirector's man file & Makefile..
Wed, Jan 7, 9:05 PM · Contributor Reviews (src)
ziaee updated the diff for D54586: mdoc: SYNOPISIS should not have prose.

make mdoc(7) a bit clearer

Wed, Jan 7, 8:50 PM
ziaee requested review of D54586: mdoc: SYNOPISIS should not have prose.
Wed, Jan 7, 8:42 PM
ziaee added inline comments to D44458: coredirector - Intel TD/HFI driver - Part6: Add coredirector's man file & Makefile..
Wed, Jan 7, 6:55 PM · Contributor Reviews (src)
ziaee added a reviewer for D44458: coredirector - Intel TD/HFI driver - Part6: Add coredirector's man file & Makefile.: manpages.
Wed, Jan 7, 6:52 PM · Contributor Reviews (src)
ziaee committed rG98b9f1dcbc0c: mrsas.4: Cleaning.
Wed, Jan 7, 2:02 PM
ziaee added a comment to D54571: mrsas.4: Synchronize with CURRENT.

Also, in your last commit to stable/13, you violated two rules:

Wed, Jan 7, 2:00 PM
ziaee requested changes to D54571: mrsas.4: Synchronize with CURRENT.

I finished MFCing my end. Now, you should wait two days minimum, and then if nobody complains, you switch to the stable branches and git cherry-pick -x ccec94bf63d. This is written in the comitters guide.

Wed, Jan 7, 1:56 PM
ziaee committed rGac8b22b3732a: mrsas.4: Cleaning.
Wed, Jan 7, 1:53 PM
ziaee added a comment to D54571: mrsas.4: Synchronize with CURRENT.

This is mostly my commit, I will MFC it, then you should be able to MFC yours without conflict

Wed, Jan 7, 1:08 PM
ziaee added a comment to D54571: mrsas.4: Synchronize with CURRENT.

We don't really do it this way. If you want to sync this manual with current, you MFC the changes. It's a lot easier then to keep track of everything, and not have merge conflicts.

Wed, Jan 7, 1:02 PM

Tue, Jan 6

ziaee committed rG1961785e3548: pxeboot.8: Fix mdoc typo for emails, tag spdx.
Tue, Jan 6, 10:49 PM
ziaee accepted D54356: iflib: Drop tx lock when freeing mbufs using simple_transmit.

Manual LGTM, idk about the code.

Tue, Jan 6, 9:29 PM
ziaee accepted D54566: mrsas.4: Add Fujitsu RAID Controller SAS 6Gbit/s 1GB (D3116).

Okay, I'm fine now. Thanks!

Tue, Jan 6, 9:28 PM
ziaee accepted D54564: iflib: document new sysctls.
Tue, Jan 6, 9:27 PM
ziaee added a comment to D54566: mrsas.4: Add Fujitsu RAID Controller SAS 6Gbit/s 1GB (D3116).

This list is by controller, and the 2208 controller is already listed, so this would make the table inconsistent. I think we should not add it to this table.

Tue, Jan 6, 9:04 PM
ziaee added a comment to D54564: iflib: document new sysctls.

Thanks for doing this!

Tue, Jan 6, 8:25 PM
ziaee added a reviewer for D54356: iflib: Drop tx lock when freeing mbufs using simple_transmit: manpages.

Note that deferred mbuf freeing is not enabled by default, and can be

enabled using the dev.$DEV.$UNIT.iflib.tx_defer_mfree sysctl.

Tue, Jan 6, 6:36 PM
ziaee requested review of D54563: 15.0/errata: Mention possiblity of disabling ipfw.
Tue, Jan 6, 5:55 PM
ziaee committed rG2962dc768775: sh.1: Restore missing builtin commands.
Tue, Jan 6, 5:33 PM
ziaee committed rG75866d71e8d9: manuals: Correct some sysctl markup.
Tue, Jan 6, 4:10 PM
ziaee added a comment to D54520: mfi(4): Add subvendor and subdevice for Fujitsu RAID Controller SAS 6Gbit/s 1GB (D3116).

In fact, mrsas(4) mentions:

HARDWARE
     The mrsas driver supports the following hardware:

     [ Thunderbolt 6Gb/s MR controller ]
     •   LSI MegaRAID SAS 9265
     •   LSI MegaRAID SAS 9266
     •   LSI MegaRAID SAS 9267
     •   LSI MegaRAID SAS 9270
     •   LSI MegaRAID SAS 9271
     •   LSI MegaRAID SAS 9272
     •   LSI MegaRAID SAS 9285
     •   LSI MegaRAID SAS 9286
     •   DELL PERC H810
     •   DELL PERC H710/P

     [ Invader/Fury 12Gb/s MR controller ]
     •   LSI MegaRAID SAS 9380
     •   LSI MegaRAID SAS 9361
     •   LSI MegaRAID SAS 9341
     •   DELL PERC H830
     •   DELL PERC H730/P
     •   DELL PERC H330

Let me evaluate this in a separate review.

Tue, Jan 6, 3:33 PM
ziaee added a comment to D54520: mfi(4): Add subvendor and subdevice for Fujitsu RAID Controller SAS 6Gbit/s 1GB (D3116).

I see, thanks michaelo!

Tue, Jan 6, 3:11 PM
ziaee committed rG03e1605cdf17: cxgbe.4: Update for recent HARDWARE.
Tue, Jan 6, 2:54 PM
ziaee closed D54276: cxgbe.4: Update for recent HARDWARE.
Tue, Jan 6, 2:53 PM
ziaee accepted D54520: mfi(4): Add subvendor and subdevice for Fujitsu RAID Controller SAS 6Gbit/s 1GB (D3116).

If it works for both, should we list it for both?

Tue, Jan 6, 2:47 PM
ziaee added inline comments to D53910: website: complete refresh of beastie theme.
Tue, Jan 6, 1:19 PM
ziaee added a reviewer for D54519: mfi(4)/mrsas(4): Print driver versions consistently: emaste.

Thanks for tagging me!

Tue, Jan 6, 3:48 AM
ziaee added a reviewer for D54519: mfi(4)/mrsas(4): Print driver versions consistently: imp.
Tue, Jan 6, 3:48 AM

Mon, Jan 5

ziaee added a comment to D54538: makefs.8: Cleanup man page.

don't forget to fix the commit message typo!

Mon, Jan 5, 10:25 PM
ziaee accepted D54538: makefs.8: Cleanup man page.
Mon, Jan 5, 9:20 PM
ziaee foisted D54054: ctfmerge.1: needs to document environment variable use upon wosch.

Woah, sorry I hit the wrong button, which you can't deselect on phabricator mobile. Did not intend to commander revision!

Mon, Jan 5, 6:42 PM
ziaee commandeered D54054: ctfmerge.1: needs to document environment variable use.
Mon, Jan 5, 6:41 PM