In D44494#1014836, @imp wrote:

Change looks good, but you'll want to edit the 'subject' of the commit message to be < 70 characters

In D44422#1013860, @mav wrote:

I am not a big fan of kernel printing something in response to arbitrary user requests, it makes logs messy. Is the error reporting to user is not enough here?

If we keep the printfs, while device_printf() is better than just printf() used in other places (that is dirty), shouldn't we better use mpi3mr_dprint(), respecting configured driver debug level? I see there even special MPI3MR_DEBUG_IOCTL level for IOCTL's.

In D44426#1013880, @mav wrote:

I don't have any chip documentation to know what is right here, so just wonder if unconditional printing a bunch of raw hex numbers is expected here. It feels mpi3mr_print_fault_info() is another candidate for mpi3mr_dprint().

In D44423#1013705, @imp wrote:

Fine as it is if the same sort of redundancy is done elsewhere

In D44423#1013689, @sumit.saxena_broadcom.com wrote:

Need to adjust patch description a bit to keep code changes and description better aligned.

Hi Warner,