unused variable

rf

In D54576#1247249, @mckusick wrote:

You do not specify what happens if both -U and -u are specified. In practice, whichever one is second wins out. I think it should be flagged as an error.

can you also fix the padding in tcp-state?

Your use of “Obtained from” is incorrect, unless “Hewlett Packard Enterprise” is the name of a piece of open-source software I've never heard of that has a copy of our libutil and already had this patch. You probably want to use “Sponsored by” instead.

There is no reason not to allow EDDSA. It just did not yet exist when this script was written.

In D54440#1244012, @bz wrote:

I think I would also always put an (at least) MPASS in there that res is not NULL.

I've verified that graphics/drm-66-kmod builds cleanly with these changes.

In D54016#1243879, @jlduran wrote:

In D54016#1243870, @des wrote:

What's the point of copying the NetBSD tests if we end up having to change everything about them, and then end up adding our own test script anyway as you do in D54265?

I tried to #ifdef this test, but it soon became obvious we should branch out (it became unreadable).

The summary is incorrect. Early operating systems including DEC's TOPS-10 and VMS used CR LF because that was what teletypes expected. CP/M was heavily inspired by TOPS-10 and continued to use CR LF despite rarely if ever being used with teletypes. DOS inherited CR LF from CP/M, and Windows inherited it from DOS; Windows NT and OS/2 borrowed heavily from VMS which also used CR LF, in addition to needing to remain compatible with DOS and pre-NT Windows. Apple historically used CR but switched to LF with Mac OS X (later renamed to macOS). Unix and its descendants (such as Plan 9) have always used LF despite originally being written for teletypes, relying instead on the device driver to inject a CR if needed.

What's the point of copying the NetBSD tests if we end up having to change everything about them, and then end up adding our own test script anyway as you do in D54265?

I did indeed write sockstat(8) but I did not write (most of) formataddr(), and I certainly would not have approved it if asked to review it.