Page MenuHomeFreeBSD

jaeyoon (Jaeyoon Choi)
User

Projects (2)

User Details

User Since
Jan 3 2025, 1:07 AM (55 w, 1 d)

Recent Activity

Mon, Jan 5

jaeyoon added a reviewer for D54513: ufshci: Remove UIC error during initialization: imp.
Mon, Jan 5, 5:00 AM
jaeyoon requested review of D54513: ufshci: Remove UIC error during initialization.
Mon, Jan 5, 4:59 AM
jaeyoon committed rGece6e062ae4b: ufshci: Enable admin command retry.
Mon, Jan 5, 2:39 AM
jaeyoon committed rGef2d7cc11d04: ufshci: Fix task management queue num_trackers on failure path.
Mon, Jan 5, 2:39 AM
jaeyoon closed D54244: ufshci: Enable admin command retry.
Mon, Jan 5, 2:39 AM
jaeyoon closed D54243: ufshci: Fix task management queue num_trackers on failure path.
Mon, Jan 5, 2:39 AM
jaeyoon added a comment to D54244: ufshci: Enable admin command retry.

Thank you for the review!

Mon, Jan 5, 2:09 AM
jaeyoon added a comment to D54243: ufshci: Fix task management queue num_trackers on failure path.

Thank you for the review!

Mon, Jan 5, 2:09 AM

Dec 16 2025

jaeyoon updated the diff for D54244: ufshci: Enable admin command retry.

Remove is_admin = false in ufshci_ctrlr_submit_task_mgmt_request

Dec 16 2025, 5:36 AM
jaeyoon requested review of D54244: ufshci: Enable admin command retry.
Dec 16 2025, 5:31 AM
jaeyoon requested review of D54243: ufshci: Fix task management queue num_trackers on failure path.
Dec 16 2025, 5:31 AM

Dec 12 2025

jaeyoon accepted D54184: cam: Also reduce timeout for wlun probing.

Thank you!

Dec 12 2025, 3:29 AM

Dec 8 2025

jaeyoon added a comment to R11:51cb57c4fee5: sysutils/bsdisks: Fix build on latest 16-CURRENT.

Thank you for fixing this!

Dec 8 2025, 6:00 AM

Dec 3 2025

jaeyoon committed rG0e60cb8c6a4e: ufshci: Add a Auto Hibernate quirk to Intel Alder Lake-N.
Dec 3 2025, 4:07 AM
jaeyoon committed rGdb8b06468bae: ufshci: Support UIC Auto Hibernation.
Dec 3 2025, 4:07 AM
jaeyoon committed rGbec77e3a160d: ufshci: Support UIC hibernation enter/exit.
Dec 3 2025, 4:07 AM
jaeyoon committed rG3a99f31fdb6c: ufshci: Support suspend/resume.
Dec 3 2025, 4:07 AM
jaeyoon closed D54006: ufshci: Add a Auto Hibernate quirk to Intel Alder Lake-N.
Dec 3 2025, 4:07 AM
jaeyoon closed D54004: ufshci: Support UIC Auto Hibernation.
Dec 3 2025, 4:07 AM
jaeyoon closed D54003: ufshci: Support UIC hibernation enter/exit.
Dec 3 2025, 4:06 AM
jaeyoon closed D54002: ufshci: Support suspend/resume.
Dec 3 2025, 4:06 AM

Dec 2 2025

jaeyoon added a comment to D54002: ufshci: Support suspend/resume.

After this fix, the following two reviews have been rebased and are ready for approval:
https://reviews.freebsd.org/D54003
https://reviews.freebsd.org/D54004

Dec 2 2025, 7:49 AM
jaeyoon updated the diff for D54004: ufshci: Support UIC Auto Hibernation.

rebase

Dec 2 2025, 7:45 AM
jaeyoon updated the diff for D54003: ufshci: Support UIC hibernation enter/exit.

rebase

Dec 2 2025, 7:43 AM
jaeyoon updated the diff for D54002: ufshci: Support suspend/resume.

Use device_suspend/device_resume

Dec 2 2025, 7:41 AM
jaeyoon added inline comments to D54002: ufshci: Support suspend/resume.
Dec 2 2025, 5:16 AM
jaeyoon added a reviewer for D54006: ufshci: Add a Auto Hibernate quirk to Intel Alder Lake-N: imp.
Dec 2 2025, 3:33 AM

Dec 1 2025

jaeyoon requested review of D54006: ufshci: Add a Auto Hibernate quirk to Intel Alder Lake-N.
Dec 1 2025, 7:58 AM
jaeyoon requested review of D54004: ufshci: Support UIC Auto Hibernation.
Dec 1 2025, 6:47 AM
jaeyoon requested review of D54003: ufshci: Support UIC hibernation enter/exit.
Dec 1 2025, 6:47 AM
jaeyoon requested review of D54002: ufshci: Support suspend/resume.
Dec 1 2025, 6:47 AM
jaeyoon abandoned D54000: ufshci: Support suspend/resume.
Dec 1 2025, 6:47 AM
jaeyoon abandoned D54001: ufshci: Support UIC Auto Hibernation.
Dec 1 2025, 6:47 AM
jaeyoon requested review of D54001: ufshci: Support UIC Auto Hibernation.
Dec 1 2025, 6:46 AM
jaeyoon requested review of D54000: ufshci: Support suspend/resume.
Dec 1 2025, 6:45 AM
jaeyoon added a comment to D53375: cam/scsi, ufshci: Add Well-known LUN Probing.
In D53375#1233119, @imp wrote:

OK. I understand adding the quirk. It may make sense for us to handle some of these 'probing' commands better in the future, but we have many others than the ones you've added. As such, lets go wit the the PIM_WLUN flag for now.

Dec 1 2025, 6:25 AM
jaeyoon abandoned D53375: cam/scsi, ufshci: Add Well-known LUN Probing.
Dec 1 2025, 6:24 AM
jaeyoon committed rG8c35de4982d8: cam/scsi: Add power condition support to START STOP UNIT.
Dec 1 2025, 6:24 AM
jaeyoon committed rG31407551c3d4: ufshci: Add a check for WLUN during driver initialization.
Dec 1 2025, 6:24 AM
jaeyoon committed rG5e0d065b5b90: ufshci: Enable WLUN scan.
Dec 1 2025, 6:23 AM
jaeyoon committed rGba963776199f: cam/scsi: Support well known logical unit.
Dec 1 2025, 6:23 AM
jaeyoon committed rG3e3d7e590566: ufshci: add helper to convert SCSI LUN to UPIU LUN formats.
Dec 1 2025, 6:23 AM
jaeyoon closed D53922: cam/scsi: Add power condition support to START STOP UNIT.
Dec 1 2025, 6:23 AM
jaeyoon closed D53923: ufshci: Add a check for WLUN during driver initialization.
Dec 1 2025, 6:23 AM
jaeyoon closed D53921: ufshci: Enable WLUN scan.
Dec 1 2025, 6:23 AM
jaeyoon closed D53919: ufshci: add helper to convert SCSI LUN to UPIU LUN formats.
Dec 1 2025, 6:23 AM
jaeyoon closed D53920: cam/scsi: Support well known logical unit.
Dec 1 2025, 6:23 AM
jaeyoon added inline comments to D53920: cam/scsi: Support well known logical unit.
Dec 1 2025, 6:15 AM
jaeyoon closed D53997: releases/15.0R/relnotes: Add ufshci(4).
Dec 1 2025, 1:36 AM
jaeyoon committed R9:7917f323af55: releases/15.0R/relnotes: Add ufshci(4).
Dec 1 2025, 1:36 AM
jaeyoon added a reviewer for D53997: releases/15.0R/relnotes: Add ufshci(4): lwhsu.
Dec 1 2025, 1:04 AM
jaeyoon added a comment to D53997: releases/15.0R/relnotes: Add ufshci(4).

I'm sorry for being late. I completely forgot.

Dec 1 2025, 1:03 AM
jaeyoon added reviewers for D53997: releases/15.0R/relnotes: Add ufshci(4): imp, ziaee, releng.
Dec 1 2025, 1:02 AM
jaeyoon requested review of D53997: releases/15.0R/relnotes: Add ufshci(4).
Dec 1 2025, 1:00 AM

Nov 26 2025

jaeyoon reclaimed D53375: cam/scsi, ufshci: Add Well-known LUN Probing.

Reopen until the current comment is resolved.

Nov 26 2025, 10:23 AM
jaeyoon added a reviewer for D53923: ufshci: Add a check for WLUN during driver initialization: imp.
Nov 26 2025, 9:54 AM
jaeyoon added a reviewer for D53922: cam/scsi: Add power condition support to START STOP UNIT: imp.
Nov 26 2025, 9:54 AM
jaeyoon added a reviewer for D53921: ufshci: Enable WLUN scan: imp.
Nov 26 2025, 9:53 AM
jaeyoon added a reviewer for D53920: cam/scsi: Support well known logical unit: imp.
Nov 26 2025, 9:53 AM
jaeyoon added a comment to D53919: ufshci: add helper to convert SCSI LUN to UPIU LUN formats.

Please approve this review again. Sorry for confusion.

Nov 26 2025, 9:52 AM
jaeyoon abandoned D53375: cam/scsi, ufshci: Add Well-known LUN Probing.
Nov 26 2025, 9:51 AM
jaeyoon added a comment to D53375: cam/scsi, ufshci: Add Well-known LUN Probing.

This review has been split into the following 5 reviews. Please check the following reviews.
Sorry for the confusion.

Nov 26 2025, 9:50 AM
jaeyoon added a reviewer for D53919: ufshci: add helper to convert SCSI LUN to UPIU LUN formats: imp.
Nov 26 2025, 9:46 AM
jaeyoon abandoned D53376: ufshci: add helper to convert SCSI LUN to UPIU LUN formats.

Please accept again same commit: https://reviews.freebsd.org/D53919

Nov 26 2025, 9:44 AM
jaeyoon requested review of D53923: ufshci: Add a check for WLUN during driver initialization.
Nov 26 2025, 9:38 AM
jaeyoon requested review of D53922: cam/scsi: Add power condition support to START STOP UNIT.
Nov 26 2025, 9:38 AM
jaeyoon requested review of D53921: ufshci: Enable WLUN scan.
Nov 26 2025, 9:38 AM
jaeyoon requested review of D53920: cam/scsi: Support well known logical unit.
Nov 26 2025, 9:38 AM
jaeyoon requested review of D53919: ufshci: add helper to convert SCSI LUN to UPIU LUN formats.
Nov 26 2025, 9:37 AM
jaeyoon updated the diff for D53375: cam/scsi, ufshci: Add Well-known LUN Probing.
  • cam/scsi: Support well known logical unit
  • ufshci: Enable WLUN scan
  • cam/scsi: Add power condition support to START STOP UNIT
  • ufshci: Add a check for WLUN during driver initialization
Nov 26 2025, 8:54 AM
jaeyoon added a comment to D53375: cam/scsi, ufshci: Add Well-known LUN Probing.

Thanks for the review~!

Nov 26 2025, 8:47 AM
jaeyoon reclaimed D53375: cam/scsi, ufshci: Add Well-known LUN Probing.

Oh, you left a review here. I'll reopen it.

Nov 26 2025, 2:58 AM
jaeyoon abandoned D53375: cam/scsi, ufshci: Add Well-known LUN Probing.

We'll review each patch individually.
https://reviews.freebsd.org/D53376

Nov 26 2025, 2:51 AM

Nov 6 2025

jaeyoon added a comment to D53375: cam/scsi, ufshci: Add Well-known LUN Probing.

This patch is ready for the review!

Nov 6 2025, 4:20 AM

Nov 2 2025

jaeyoon reclaimed D53375: cam/scsi, ufshci: Add Well-known LUN Probing.
Nov 2 2025, 11:46 PM

Oct 27 2025

jaeyoon added a reviewer for D53376: ufshci: add helper to convert SCSI LUN to UPIU LUN formats: imp.
Oct 27 2025, 7:27 AM
jaeyoon requested review of D53376: ufshci: add helper to convert SCSI LUN to UPIU LUN formats.
Oct 27 2025, 7:26 AM
jaeyoon abandoned D53375: cam/scsi, ufshci: Add Well-known LUN Probing.

I will request a review for each commit individually to make reviewing easier.

Oct 27 2025, 7:06 AM
jaeyoon updated the summary of D53375: cam/scsi, ufshci: Add Well-known LUN Probing.
Oct 27 2025, 7:02 AM
jaeyoon requested review of D53375: cam/scsi, ufshci: Add Well-known LUN Probing.
Oct 27 2025, 6:59 AM

Oct 23 2025

jaeyoon committed rG131dc2b7ad1b: MAINTAINERS: Add myself to ufshci.
Oct 23 2025, 3:17 AM
jaeyoon closed D53253: MAINTAINERS: Add myself to ufshci.
Oct 23 2025, 3:17 AM

Oct 22 2025

jaeyoon added a reviewer for D53253: MAINTAINERS: Add myself to ufshci: imp.
Oct 22 2025, 7:15 AM
jaeyoon requested review of D53253: MAINTAINERS: Add myself to ufshci.
Oct 22 2025, 7:15 AM

Sep 18 2025

jaeyoon committed rG6b841d70960a: ufshci: revisit controller reset path and add I/O timeout handling.
Sep 18 2025, 2:42 PM
jaeyoon closed D52440: ufshci: revisit controller reset path and add I/O timeout handling.
Sep 18 2025, 2:42 PM
jaeyoon committed rG380e4a8233c8: committers-src: add myself (jaeyoon@).
Sep 18 2025, 2:36 PM
jaeyoon closed D52570: committers-src: add myself (jaeyoon@).
Sep 18 2025, 2:35 PM
jaeyoon closed D52569: new committer (src): Jaeyoon Choi (jaeyoon).
Sep 18 2025, 1:44 PM
jaeyoon committed R9:8a349c977b40: new committer (src): Jaeyoon Choi (jaeyoon).
Sep 18 2025, 1:44 PM

Sep 16 2025

jaeyoon added a reviewer for D52570: committers-src: add myself (jaeyoon@): imp.
Sep 16 2025, 9:43 AM
jaeyoon requested review of D52570: committers-src: add myself (jaeyoon@).
Sep 16 2025, 9:43 AM
jaeyoon added a reviewer for D52569: new committer (src): Jaeyoon Choi (jaeyoon): imp.
Sep 16 2025, 9:25 AM
jaeyoon requested review of D52569: new committer (src): Jaeyoon Choi (jaeyoon).
Sep 16 2025, 9:24 AM

Sep 13 2025

bofh renamed jaeyoon.
Sep 13 2025, 10:38 AM

Sep 12 2025

jaeyoon added a comment to D52440: ufshci: revisit controller reset path and add I/O timeout handling.
In D52440#1198791, @imp wrote:

So this change is a bit larger than I like to review. But the moved code was simple (and I know I have comment about the moved code, and that maybe the NVMe driver isn't good about doing it true). In the future, though it would make it easiest if you had the 'move it' commits separate from the rest. The place I want a comment could get one later too, if that's easier to do.

Looking at the recovery algorithm, it does seem quite similar to the NVMe one. The only concern I have here is that we'll need to track it in two places. I've been tweaking it from time to time in the nvme driver, but I don't know how applicable future tweaks will be. I guess this is more of a "be aware" in the future comment.

Sep 12 2025, 1:33 AM
jaeyoon updated the diff for D52440: ufshci: revisit controller reset path and add I/O timeout handling.

Add a comment

Sep 12 2025, 1:13 AM

Sep 11 2025

jaeyoon updated the diff for D52440: ufshci: revisit controller reset path and add I/O timeout handling.

update commit log

Sep 11 2025, 5:48 AM
jaeyoon updated the diff for D52440: ufshci: revisit controller reset path and add I/O timeout handling.

Fix queue contruct sequence

Sep 11 2025, 4:53 AM

Sep 9 2025

jaeyoon added reviewers for D52440: ufshci: revisit controller reset path and add I/O timeout handling: imp, julian.
Sep 9 2025, 4:50 AM