Any other opinions?

In D44356#1011926, @jrm wrote:

@cperciva, it would be good to get your approval here as well.

@vvd, do you want to update this review?

Removed inline patch in favor of remote one.

fetch patch from remote

In D44338#1011233, @ale wrote:

I think you should change the WWW entry to point to 1.3

apply comments from ale@

This is now a minimal change, please have a look guys.

In D44229#1009025, @jrm wrote:

FYI, devel/eclipse failed in my 15.0-CURRENT 1500008 amd64 jail.

http://pkg.ftfl.ca/data/15amd64-default/2024-03-05_13h23m40s/logs/errors/eclipse-4.24_2.log

It doesn't seem like this change should have any effect, but can you verify this?

Include java/eclipse

In D44229#1008960, @vvd wrote:

I think you can add java/eclipse here too.
Probably https://reviews.freebsd.org/D44153 isn't actual anymore.

FTR: https://reviews.freebsd.org/D44229

Address improvement proposal from @emaste.

I will take care of these:

In D43700#1006987, @emaste wrote:

What do you think about something like Run 'freebsd-update [options] install' to proceed? It offers a reminder to include the user's necessary options but retains the example style.

In D43700#1006063, @otis wrote:

Although this change looks good to me, we also should consider making -d default to $(-b)/var/db/freebsd-update. *THAT* left me with broken boot environment :-/ (I've used -b /path/to/be without -d /path/to/be/var/db/freebsd-update).

@lev, one day left, do you want to take a peek?

Address comment.

Address typo

I will give @lev two weeks to review as demanded by the maintainer timeout. So I can merge around 2024-02-27.

In D43703#1000910, @jrm wrote:

I don't have strong options either way. On the one hand, I can appreciate how this would confuse some users when they log in to a jail. On the other hand, I expect some users would miss seeing this information (by default) when they log in. While it may also be confusing, it's reporting accurate information that many would expect, i.e., version information about the running kernel.

Brainstorming ideas, what about appending something like this to /var/run/motd?

echo "$(hostname) $(uname -smi) running kernel/userland: $(uname -r)/$(freebsd-version -u)"

In a 14 jail running on a 15-CURRENT host, the output looks like this.

myhostname FreeBSD amd64 GENERIC-NODEBUG running kernel/userland: 15.0-CURRENT/14.0-RC4

Ran three sets in poudiere:

In D42720#996866, @glewis wrote:

This version looks good to me. Thanks!

This one comes from: https://github.com/BastilleBSD/bastille/issues/393

@emaste, as discussed, here it is.

Credits go to @dim!

@glewis, as discussed last year I have rewritten the solution using a make variable. Verfied for all affected OpenJDK versions with a Maven build against our internal Nexus instance and expected failure with 18, 19, 20 which I did not touch.

Implement with a variable in make.conf

I'll pick this up again next year.