Thanks for fixing this Mark! Looks good to me.

In D14289#313281, @allanjude wrote:

Coverity found a number of issues with this commit. It is possible they are false positives:

• CID 1056844: API usage errors (SWAPPED_ARGUMENTS)

/sys/dev/vmware/vmci/vmci_qpair.c: 400 in vmci_qpair_consume_free_space()
394
395 if (!qpair)
396 return (VMCI_ERROR_INVALID_ARGS);
397
398 vmci_qpair_get_queue_headers(qpair, &produce_q_header,
399 &consume_q_header);

CID 1056844:  API usage errors  (SWAPPED_ARGUMENTS)
The positions of arguments in the call to "vmci_queue_header_free_space" do not match the ordering of the parameters:

• "consume_q_header" is passed to "produce_q_header"
• "produce_q_header" is passed to "consume_q_header"

400 result = vmci_queue_header_free_space(consume_q_header, produce_q_header,
401 qpair->consume_q_size);
402
403 return (result);
404 }
405

• CID 1056845: API usage errors (SWAPPED_ARGUMENTS)

/sys/dev/vmware/vmci/vmci_qpair.c: 320 in vmci_qpair_get_consume_indexes()

• CID 1056846: API usage errors (SWAPPED_ARGUMENTS)

/sys/dev/vmware/vmci/vmci_qpair.c: 438 in vmci_qpair_produce_buf_ready()

Thank you Mark!

@imp Thank you Warner! I have made the change that you suggested.

Change path in Makefile

Ping. Gentle reminder.

In D14289#299838, @bcr wrote:

Looks good now. OK from the manpages part of the module.

Add socket(2) to SEE ALSO section in man page.

Thank you @bcr! I've added AUTHORS, HISTORY and SEE ALSO section to the man
page.

Fixed formatting errors in man page. Used igor to proofread the document after
the changes.

In D14289#299768, @bcr wrote:

A few comments on the man page. You can use textproc/igor to check the man page for various common errors.
Thank you very much for working on this kernel module!

Remove unnecessary newline with SUBDIR+= in the upper level Makefile at vmxnet3.
Use more SRCS+= to keep the list to below 80 characters.

Fix the file permissions to be 644