Looks great, thanks!

Fix mandoc -T lint warnings:

• Replace smart quotation mark.
• Wrap the line to 80 characters.

But I also have one more question: one of the warnings is also about unexisting .Xr sysctl 2. As I can see, there is no sysctl(2) in FreeBSD, only sysctl(3). But the man pages talks about it in the context of syscalls, so it seems that we can't just change sysctl(2) to sysctl(3) since sysctl(3) is not a syscall. What sould we do about that?

In D54761#1251631, @jlduran wrote:

In D54761#1251514, @tembun_bk.ru wrote:

In D54761#1251476, @jlduran wrote:

If possible, try to fix all the mandoc -T lint share/man/man4/capsicum.4 recommendations while here.

Sure. One of the warnings is: STYLE: referenced manual not found: Xr pdwait4 2. As I can see, pdwait(2) syscall is about to be introduced by https://reviews.freebsd.org/D54592 soon. So shall we keep the reference to pdwait4(2) (but change it to pdwait(2))?

We've never had pdwait4. There are other references to pdwait4(2) in related man pages, I would prefer to remove all of them separately.

In D54761#1251514, @tembun_bk.ru wrote:

In D54761#1251476, @jlduran wrote:

If possible, try to fix all the mandoc -T lint share/man/man4/capsicum.4 recommendations while here.

Sure. One of the warnings is: STYLE: referenced manual not found: Xr pdwait4 2. As I can see, pdwait(2) syscall is about to be introduced by https://reviews.freebsd.org/D54592 soon. So shall we keep the reference to pdwait4(2) (but change it to pdwait(2))?

In D54761#1251476, @jlduran wrote:

If possible, try to fix all the mandoc -T lint share/man/man4/capsicum.4 recommendations while here.

Thanks. The "fi" ligature was probably an artifact from copy/pasting from the PDF article.
If possible, try to fix all the mandoc -T lint share/man/man4/capsicum.4 recommendations while here.

I guess that it would be a good idea to add the commit hash of this patch into the .git-blame-ignore-revs file.

Implement improvements suggested by @glebius.

I think this looks great! Let's wait for a second opinion on the content and then I'd be happy to take this.

This is such a beautifully structured manual. People often abuse .Sh when really they should be subsections of DESCRIPTION. Thanks for the patch Artem!

In D54688#1250515, @ziaee wrote:

I still do (nonblocking, if anyone else is free) but I'm swamped at $dayjob and idk when I'll be able to get to it.

I still do (nonblocking, if anyone else is free) but I'm swamped at $dayjob and idk when I'll be able to get to it.

@ziaee You also wanted to test this :)

Thanks for the ping! I get busy and forget about stuff so I really appreciate pings!

Ping @ziaee?

s/Jan/January/ in .Dd.

Fix the wording (suggested by kib).

Better integrate stack(9) reference into the sentence.

You need to explain what you put into the summary, in the man page itself. Otherwise the reference to stack(9) looks out of context.

Ah, I misunderstood then, sorry. Over lunch I'll test this.

In D54688#1249743, @ziaee wrote:

I don't think this is the diff you intended to upload based on the commit message title.

I don't think this is the diff you intended to upload based on the commit message title. Also, please format patches with -U9999 so we can see the context

Update diff with -U9999.

Update diff with -U9999.

Update diff with -U9999.

Also, please update diffs with -U9999 so we can see all the context. Alternatively, try using src/tools/tools/git/git-arc.sh, which also has a manual in that dir too.

In D54114#1244827, @ziaee wrote:

Sorry I haven't had time to review this yet!

I don't know about adding mlinks. We can't really do it consistently without creating a lot of collision in the apropos database, which is hard for beginners to navigate.

Cross-reference _exit(2) from atexit(3).

Add SPDX-License-Identifier.

In D54467#1244846, @ziaee wrote:

We're a bit outside my expertise here, but initial thoughts:

atexit(3) is one of the cases when _exit(2) must be used instead of exit(3).

Shouldnt the cross-reference go the other way for discoverability then? atexit should link to _exit(2)?

We're a bit outside my expertise here, but initial thoughts:

Sorry I haven't had time to review this yet!

Bump .Dd.